Skip to content

Add assignment_1 solutions#1

Open
Afroz-Popatiya wants to merge 1 commit intomainfrom
assignment-1
Open

Add assignment_1 solutions#1
Afroz-Popatiya wants to merge 1 commit intomainfrom
assignment-1

Conversation

@Afroz-Popatiya
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Adding code

What did you learn from the changes you have made?

How to use python

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

NA

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Git

How were these changes tested?

Help through office hours

A reference to a related issue in your repository (if applicable)

NA

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Your code is clean and well-written and your PR description is clear. Your assignment 1 is complete – no changes needed.

Please see my minor suggestions for future improvement:

  • Instead of if not is_case_sensitive == True:, you can use if not is_case_sensitive:. That way your code is cleaner
  • For part 2, you can move return sorted(word_a) == sorted(word_b) outside the if statement since it is shared by both conditions.
  • It’s good practice to add comments or brief documentation to your code so it’s easier for you to review and debug later, and for teammates to understand quickly.

Afroz-Popatiya pushed a commit that referenced this pull request Jan 14, 2026
Afroz-Popatiya pushed a commit that referenced this pull request Jan 14, 2026
Update live code and assignment #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants