Open
Conversation
xindizhang
approved these changes
Dec 4, 2025
xindizhang
left a comment
There was a problem hiding this comment.
Excellent work! Your code is clean and well-written and your PR description is clear. Your assignment 1 is complete – no changes needed.
Please see my minor suggestions for future improvement:
- Instead of
if not is_case_sensitive == True:, you can useif not is_case_sensitive:. That way your code is cleaner - For part 2, you can move
return sorted(word_a) == sorted(word_b)outside theifstatement since it is shared by both conditions. - It’s good practice to add comments or brief documentation to your code so it’s easier for you to review and debug later, and for teammates to understand quickly.
Afroz-Popatiya
pushed a commit
that referenced
this pull request
Jan 14, 2026
Afroz-Popatiya
pushed a commit
that referenced
this pull request
Jan 14, 2026
Update live code and assignment #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code
What did you learn from the changes you have made?
How to use python
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
NA
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Git
How were these changes tested?
Help through office hours
A reference to a related issue in your repository (if applicable)
NA
Checklist