Add new Tabbing stragety for root blocks.#3
Open
Agapanthus wants to merge 1 commit intoAgapanthus:masterfrom
Open
Add new Tabbing stragety for root blocks.#3Agapanthus wants to merge 1 commit intoAgapanthus:masterfrom
Agapanthus wants to merge 1 commit intoAgapanthus:masterfrom
Conversation
By default, MathQuill allows the browser to handle Tab in the standard way when the cursor is in the root block. This means that the user will move to the next focusable element in tab order. This behavior bypasses any templates between the current cursor position and the end. If templates are thought of as editable areas, like mini-textfields, this approach feels unexpected to keyboard users, who would expect 'focus' to traverse to the next 'field,' i.e. next template. This commit adds a new configuration property: tabAction. By default tabAction simply uses the current behavior. Users can specify a value of 'escapeAndTemplate' to allow Tabs from the root block to find the next template or to move outside of the MathQuill field if no templates exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, MathQuill allows the browser to handle Tab in the standard way
when the cursor is in the root block. This means that the user will move to
the next focusable element in tab order. This behavior bypasses any templates
between the current cursor position and the end.
If templates are thought of as editable areas, like mini-textfields, this
approach feels unexpected to keyboard users, who would expect 'focus' to
traverse to the next 'field,' i.e. next template.
This commit adds a new configuration property: tabAction. By default tabAction
simply uses the current behavior. Users can specify a value of
'escapeAndTemplate' to allow Tabs from the root block to find the next template
or to move outside of the MathQuill field if no templates exist.