Draft
Conversation
Author
|
@AlexCharlton please take a look. Does the general direction look good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for reading/writing MIDI (at least the basic fixed size messages) with
no_stdand noalloc.The idea is that all methods that used to write to
Vec<u8>are now abstract overimpl Write<Error = E>, whichVecimplements naturally.I also added optional
defmtimplementations for library types for debugging.I used this code about 10 commits ago in a real embedded project and it worked perfectly.
Since then more message types were added and I rebased the patch with the help of Codex.
I fully reviewed it's changes on top of mine and they all are consistent. It only needed to fix a couple of newly added messages.
I'll deploy the changes in the embedded project and move the PR out of Draft status shortly.