1.21 Port Bug Fix #220
Open
1.21 Port Bug Fix #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d override useWithoutItem
…display properties
…ponents for item data handling
There was a problem hiding this comment.
Pull request overview
This PR ports the Citadel mod to Minecraft 1.21, updating the codebase to use the new DataComponents system introduced in 1.21 and updating various APIs to match the new Minecraft version.
Key changes:
- Migration from NBT-based item data storage to the DataComponents system
- Updated block interaction API to use
useWithoutItemmethod - Changed biome filtering from deprecated BIOME_DICT to BIOME_TAG system
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/data/citadel/neoforge/biome_modifier/mob_spawn_modifier.json | Adds new biome modifier configuration for mob spawn probability |
| src/main/resources/citadel.mixins.json | Registers new ItemBlockRenderTypesMixin for fluid render type handling |
| src/main/java/com/github/alexthe666/citadel/server/block/CitadelLecternBlock.java | Updates to use new useWithoutItem method signature from Minecraft 1.21 API |
| src/main/java/com/github/alexthe666/citadel/config/biome/CitadelBiomeDefinitions.java | Migrates from deprecated BIOME_DICT to BIOME_TAG system with updated tag names |
| src/main/java/com/github/alexthe666/citadel/client/gui/GuiBasicBook.java | Converts item tag handling from NBT to DataComponents system |
| src/main/java/com/github/alexthe666/citadel/client/CitadelItemstackRenderer.java | Migrates all item rendering logic from NBT to DataComponents system and updates vertex format usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/github/alexthe666/citadel/server/block/CitadelLecternBlock.java
Show resolved
Hide resolved
src/main/java/com/github/alexthe666/citadel/client/CitadelItemstackRenderer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/alexthe666/citadel/client/CitadelItemstackRenderer.java
Outdated
Show resolved
Hide resolved
…ting in item rendering
Owner
|
has conflicts |
…em rendering and update JSON structure for item renders
Author
|
Fixed. Since the newly merged DataComponent approach from #218 is more modern and we haven't released yet, we could fully align with this direction. But this implies that Alex's Mobs 1.21 will need updates. I will investigated the impact, and a separate PR will be submitted to address those fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix when fix AlexMobs
AlexModGuy/AlexsMobs#2317