rtsp: stabilize local consumer output and honor URL query#2153
Open
joeblack2k wants to merge 2 commits intoAlexxIT:masterfrom
Open
rtsp: stabilize local consumer output and honor URL query#2153joeblack2k wants to merge 2 commits intoAlexxIT:masterfrom
joeblack2k wants to merge 2 commits intoAlexxIT:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repackquery is providedrepack=on/offoverride behavior for callers that need to opt in or outWhy
This branch now contains the prerequisite RTSP query/repack plumbing plus the local-consumer stability fix.
In production, local RTSP self-hops like
thingino_voorkant_raw -> thingino_voorkant_mainwere exposing upstream RTP sequence and timestamp jumps to local consumers. In Frigate this showed up as repeatedbad cseq,Could not find codec parameters, andUnable to read frameserrors.With
?repack=1the same stream stayed stable, so the follow-up fix makes that behavior the default for loopback consumers while leaving remote clients unchanged unless they explicitly request repack.Validation
/root/.local/go/bin/go -C /root/work/go2rtc test ./internal/rtsp ./pkg/rtspffmpegonrtsp://127.0.0.1:8554/thingino_voorkant_rawno longer reportsbad cseqvoorkantstartup no longer reproduced the oldbad cseq/Could not find codec parameters/Unable to read framesfailure patternVoorkantconnection withoutUnable to find sync frame in rtsp prebuffer