fix(h264,homekit): add bounds guards against malformed device data#2193
Open
MechanicalCoderX wants to merge 1 commit intoAlexxIT:masterfrom
Open
fix(h264,homekit): add bounds guards against malformed device data#2193MechanicalCoderX wants to merge 1 commit intoAlexxIT:masterfrom
MechanicalCoderX wants to merge 1 commit intoAlexxIT:masterfrom
Conversation
h264 GetFmtpLine: check len(avc) >= 8 and size <= len(avc) before accessing avc[5:8] for the SPS profile bytes. A truncated SPS NALU from a misbehaving device caused an index-out-of-range panic. homekit videoToMedia: clamp profileID and level to the bounds of the videoProfiles/videoLevels tables before indexing them. A non-compliant HomeKit device advertising an out-of-range profile or level value caused an index-out-of-range panic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
h264 GetFmtpLine: checklen(avc) >= 8andsize <= len(avc)before accessingavc[5:8]for the SPS profile bytes. A truncated SPS NALU from a misbehaving device caused an index-out-of-range panic.homekit videoToMedia: clampprofileIDandlevelto the bounds of thevideoProfiles/videoLevelstables before indexing them. A non-compliant HomeKit device advertising an out-of-range profile or level value caused an index-out-of-range panic.