[PWGLF,Tutorial] Add CollisionCutsGroup utility class with automatic configurable registration #14362
+730
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BongHwi
requested review from
abmodak,
alcaliva,
alibuild,
chiarapinto,
dmallick2,
ercolessi,
fmazzasc,
gbencedi,
iravasen,
lbariogl,
lbarnby,
maciacco,
mpuccio,
njacazio,
romainschotter,
skundu692 and
smaff92
as code owners
|
O2 linter results: ❌ 0 errors, |
BongHwi
changed the title
Please consider the following formatting changes to AliceO2Group#14362
Please consider the following formatting changes to AliceO2Group#14362
Please consider the following formatting changes to AliceO2Group#14362
[MegaLinter] Apply linters automatic fixes to AliceO2Group#14362
Collaborator
Author
|
Ready to merge now. Please review it when you're free. |
Collaborator
Author
omvazque
approved these changes
Jan 2, 2026
omvazque
approved these changes
Jan 2, 2026
omvazque
approved these changes
Jan 2, 2026
abmodak
approved these changes
Jan 2, 2026
Collaborator
Author
abmodak
approved these changes
Jan 3, 2026
Collaborator
Author
|
Thanks for the final check @abmodak . now the ball is on the PWG-LF reviewers. Maybe @skundu692, @lbariogl, @njacazio, @romainschotter approve this PR? |
njacazio
approved these changes
Jan 3, 2026
vkucera
reviewed
Jan 8, 2026
vkucera
reviewed
Jan 8, 2026
| // Tutorial: Collision Cuts with Automatic Configurable Registration | ||
| // This tutorial demonstrates the new CollisionCutsGroup pattern that enables | ||
| // automatic configurable registration, reducing boilerplate from ~30 lines to ~5 lines. | ||
| struct CollisionCutsTutorial { // o2-linter: disable=name/workflow-file (Tutorial file naming convention) |
Collaborator
There was a problem hiding this comment.
Why is the disable directive here?
vkucera
reviewed
Jan 8, 2026
Collaborator
There was a problem hiding this comment.
This is clearly a workflow file. Why is it in Utils?
vkucera
reviewed
Jan 8, 2026
Collaborator
There was a problem hiding this comment.
What is the type of this file? Why does it have a def extension?
sigurdnese
pushed a commit
to sigurdnese/O2Physics
that referenced
this pull request
Jan 9, 2026
…configurable registration (AliceO2Group#14362) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new
CollisionCutsGroupclass that follows the v0SelectionGroup pattern to enable automatic configurable registration of collision event selection parameters in O2 analysis tasks.Key Changes
CollisionCutsGroupthat auto-registers all collision selection parameters via ROOT serializationEventSelectionParams.husing macro-based generationFiles Added:
PWGLF/Utils/collisionCutsGroup.h- Main class definitionPWGLF/Utils/collisionCutsGroup.cxx- Implementation with ROOT dictionaryPWGLF/Utils/collisionCutsGroupLinkDef.h- ROOT dictionary linkagePWGLF/Utils/EventSelectionFlagsMapping.def- Event selection flag mappingsTutorials/PWGLF/Utils/collisionCuts.cxx- Tutorial task demonstrating usageTutorials/PWGLF/Utils/README.md- Comprehensive documentationFiles Modified:
PWGLF/Utils/collisionCuts.h- Refactored to support the new group patternPWGLF/Utils/CMakeLists.txt- Added library build for collisionCutsGroupTutorials/PWGLF/CMakeLists.txt- Registered new Utils tutorial subdirectory