Added call to register 'intercepted' method#11
Open
desertkun wants to merge 1 commit intoAloshi:masterfrom
Open
Added call to register 'intercepted' method#11desertkun wants to merge 1 commit intoAloshi:masterfrom
desertkun wants to merge 1 commit intoAloshi:masterfrom
Conversation
… to process C++ class method call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Often you already have some code base you would like to introduce into Javascript world. But the API you have is just not ready to be used in
dukglue_register_method:You can try to wrap your object into a wrapper that would add that dukglue-ready methods, but sometimes even that is just not possible.
Say you have this class:
Then using simple wrapper that does not touch the original class:
You can bind it:
dukglue_register_intercepted_method<A>(ctx, "process", &AWrapper::process);The bound should have two additional arguments added before the args that javascript may pass:
Under the hood it behaves like
dukglue_register_methodanddukglue_register_functioncombined, since bothobj_ptrandfunc_ptrare used (honestly have no idea how it works there are way to many template magic up there).I would appreciate a comment on how to make this PR possible.