[Feature] Discord Integration (f/ ASEAN) v1.2.3 #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Proper integrations for discord-plotsystem plugin * Wrote a wrapper class `at com.alpsbte.plotsystem.utils.DiscordUtil` as a singleton to manage all discord event system * DiscordUtil is designed to ever be initialized if the discord-plotsystem exist in the class path, so Plot-System plugin can stay running even if the discord feature isn't installed * Cherry picked from 33c69e7
Some method path might still be wrong # Conflicts: # src/main/java/com/alpsbte/plotsystem/PlotSystem.java # src/main/java/com/alpsbte/plotsystem/commands/plot/CMD_Plot_Abandon.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/generator/AbstractPlotGenerator.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/utils/PlotUtils.java # src/main/java/com/alpsbte/plotsystem/core/system/review/PlotReview.java # src/main/resources/plugin.yml
* Using minutesDiff <= 75 may run 3 times a day * Edited minute-window to 60 which the actual windows will be minutesDiff < (60 / 2) (cherry picked from commit 31c6900)
* make inactivity notification for discord configurable in config.yml * make notification window calculation clearer (cherry picked from commit 0fda613)
Contributor
Author
|
3rd time the charm |
4 tasks
Zoriot
requested changes
Feb 1, 2026
Member
Zoriot
left a comment
Zoriot
left a comment
There was a problem hiding this comment.
If someone can dedicate time to it we should instead of implementing a addon api write our own proper api which ensure the same functionality. Which then addons like DiscordPlotSystem can implement.
This approach is very bad to maintain long term - short term I'm open in merging it. Also i don't like that DPS have completly own data at least some parts are duplicated.
| } | ||
|
|
||
| // Register discord Integration | ||
| org.bukkit.plugin.Plugin discordPlugin = DependencyManager.getDiscordIntegration(); |
| # How many days of inactivity it will take before a claimed plot is automatically abandoned, -2 disables it | ||
| inactivity-interval: 14 | ||
|
|
||
| # How long left (Days) until the plot gets abandon due to inactivity and the system will start pinging owner on discord |
Member
There was a problem hiding this comment.
We should not add options only for (optional) integrations. Either also use it in the plugin or find a way to have a generalized approach and configure it in DiscordPlotSystem
| * @see asia.buildtheearth.asean.discord.plotsystem.api.events.AbandonType | ||
| */ | ||
| public enum AbandonType { | ||
| /** @see asia.buildtheearth.asean.discord.plotsystem.api.events.AbandonType#INACTIVE */ |
| @@ -0,0 +1,215 @@ | |||
| /* | |||
Member
There was a problem hiding this comment.
Remove the License - we now only specify it in the root of the project for clearity
| return PlotSystem.getPlugin().getServer().getPluginManager().isPluginEnabled("WorldGuardExtraFlags"); | ||
| } | ||
|
|
||
| public static @Nullable org.bukkit.plugin.Plugin getDiscordIntegration() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FROM #175 W/ ISSUE #176
Important
Proper integrations for discord-plotsystem plugin
Wrote a wrapper class
at com.alpsbte.plotsystem.utils.DiscordUtilas a singleton to manage all discord event systemP.S. DiscordUtil is designed to ever be initialized if the
discord-plotsystemexist in the class path, so Plot-System plugin can stay running even if the discord feature isn't installed