Include AuthenticationResult in Transaction class #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emicha
reviewed
Jan 15, 2025
| class AuthenticationResult extends AbstractResponse | ||
| { | ||
| /** | ||
| * @var string |
Member
There was a problem hiding this comment.
Why not making enum representations of it, so you do not need to parse strings?
Author
There was a problem hiding this comment.
@emicha As we also support PHP 5.6 and do not validate responses in the SDK, do we still need an enum and to validate the values at the SDK level?
Member
There was a problem hiding this comment.
You do not need to validate the responses if you want, but provide a hint of what the possible values are, otherwise the person will need to read up the documentation, which defeats the purpose of an SDK in the first place.
Author
There was a problem hiding this comment.
@emicha I have updated the PHPDoc to add the possible values.
emicha
reviewed
Jan 15, 2025
emicha
reviewed
Jan 15, 2025
emicha
reviewed
Jan 15, 2025
emicha
reviewed
Jan 15, 2025
emicha
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.