-
Notifications
You must be signed in to change notification settings - Fork 12
Add config for dco2 #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: antalya
Are you sure you want to change the base?
Add config for dco2 #1293
Conversation
vzakaznikov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. Just remove the first line.
| @@ -0,0 +1,19 @@ | |||
| # Sample reference configuration file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just remove this line.
| # This configuration file is backwards compatible with the *dcoapp/app* (https://github.com/dcoapp/app) configuration file. | ||
|
|
||
| # https://github.com/cncf/dco2?#remediation-commits | ||
| allowRemediationCommits: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No remediation commits seems ok for now.
| require: | ||
| # Members are required to sign-off commits | ||
| # https://github.com/cncf/dco2?#skipping-sign-off-for-organization-members | ||
| members: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be correct. We want to skip members of the organization.
| allowRemediationCommits: | ||
| # Allow individual remediation commits | ||
| # https://github.com/cncf/dco2?#individual | ||
| individual: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok to allow for individuals to do remediation commits.
Changelog category (leave one):
This is just the config file. DCO2 is not enabled yet.
CI/CD Options
Exclude tests:
Regression jobs to run: