feat(effects): surface error message and stack trace in effects panel#61
Conversation
|
Hello, thanks for contributing 👑 will review it next week |
adxdits
left a comment
There was a problem hiding this comment.
Great 👍 my only suggestion would be that in actions-interceptor.service.ts errorMessage and errorStack are extracted and sent for every effect event, even non-error ones (where they'll be undefined). This works correctly due to JSON.stringify omitting undefined values, but it would be slightly cleaner to only compute them when event.lifecycle === 'error'
|
Thanks for the feedback and for merging! That's a fair point — computing Happy to open a small follow-up |
Closes #41
When an NgRx effect throws, the effects panel now shows the error message
inline and a collapsible stack trace — no more opening the browser console.
Changes:
core.models.ts: adderrorMessage/errorStacktoDevToolEffectEventPayloadactions-interceptor.service.ts: extract and forward error details inEFFECT_EVENTmessageseffects-panel.models.ts: adderrorMessage/errorStacktoEffectEventMessageandEffectExecutioneffects-panel.component.ts: populate error fields ineffectExecutionscomputed signaleffects-panel.component.html: render error message inline; collapsible stack trace via<details>effects-panel.component.scss: styles for error message and stack traceactions-interceptor.service.spec.ts: 3 new unit tests covering error forwarding