Merged
Conversation
Contributor
Author
|
CI seems to fail for the same reason as #1 (comment) |
Owner
|
Just bump the minimum Rust version in CI to fix the issue. |
nico-abram
added a commit
to nico-abram/seqlock
that referenced
this pull request
Oct 25, 2020
nico-abram
added a commit
to nico-abram/seqlock
that referenced
this pull request
Oct 25, 2020
nico-abram
force-pushed
the
update_parking_lot
branch
from
be2ac6d to
ff4ebec
Compare
Contributor
Author
|
Done! I skimmed the readme and didn't see any explicit mention of a MSRV to update I used 1.31 which I think is the first rust 2018 edition which I think is required for smallvec since it's using |
Contributor
Author
|
Oh, it seems smallvec is now breaking on const generics https://travis-ci.org/github/Amanieu/seqlock/jobs/738652796#L240 |
nico-abram
added a commit
to nico-abram/seqlock
that referenced
this pull request
Oct 25, 2020
nico-abram
force-pushed
the
update_parking_lot
branch
from
ff4ebec to
df9ef2b
Compare
Contributor
Author
|
I bumped it to 1.36 which seems to be what parking_lot uses in its CI https://github.com/Amanieu/parking_lot/blob/master/.github/workflows/rust.yml#L19 |
nico-abram
force-pushed
the
update_parking_lot
branch
from
df9ef2b to
408c861
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Amanieu/parking_lot#255