fix: clear error when teamId is unresolvable with a service API key#23
Merged
Conversation
…I key
send() from a live wallet fell through to a user-scoped GetTeamId query that a
service API key cannot run. Transactions now knows whether the user query is
available (canResolveTeamId) and throws a helpful PaymentSendError telling the
caller to pass { teamId } instead of firing a doomed fetch.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replace the raw JSON.stringify dump per environment/wallet with a scannable one-line summary (name, type/asset, id). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
AbortSignal.timeout timers are unref'd, so on Node 22.x the event loop could drain before the client's timeout fired — the abort never happened, run() hung, and the subtest was torn down "still pending". Hold the loop open with a ref'd timer until the abort fires. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
wthrajat
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transactions.send()from a live wallet fell through to a user-scopedGetTeamIdquery that a service API key cannot run. It now knows whether theuserquery is available (canResolveTeamId, wired fromBoolean(config.apiKey)) and throws a helpfulPaymentSendErrortelling the caller to pass{ teamId }— instead of firing a doomed fetch.JSON.stringifydumps → scannable one-line summaries (name (type) — id,name [asset] — id).Test plan
pnpm buildpnpm test— 39 pass incl. new "throws a helpful error when teamId is unresolvable (service API key only)"pnpm format:checkexamples/receive.tslive — listing + invoice mint both work🤖 Generated with Claude Code