convert humidity to float in domoticz plugin#39
Open
maarten-v wants to merge 1 commit intoAmpScm:mainfrom
Open
convert humidity to float in domoticz plugin#39maarten-v wants to merge 1 commit intoAmpScm:mainfrom
maarten-v wants to merge 1 commit intoAmpScm:mainfrom
Conversation
Member
|
I think we should also revert to the proper value in the api. This could be caused by the cloud changes?n(not sure though). Let's pass the proper values... And apply this patch to support both the bad and good types on the domoticz side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The humidity is a string, I think it was a float before looking at this remark: #30 (comment)
But it's now causing errors in domoticz: "Error updating zone device: '<' not supported between instances of 'str' and 'int'"
This converts it to float in the domoticz plugin.