WebRTC-Abhängigkeit auf 1.3.10 aktualisiert für 16KB-Seitengröße#92
Closed
Android-PowerUser wants to merge 3 commits into
Closed
WebRTC-Abhängigkeit auf 1.3.10 aktualisiert für 16KB-Seitengröße#92Android-PowerUser wants to merge 3 commits into
Android-PowerUser wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
This PR correctly updates the WebRTC dependency from version 1.1.1 to 1.3.10 in both build configuration files to address Google Play's native library alignment requirements. The changes are minimal, targeted, and have been tested to verify 16KB alignment of the native binaries. No blocking issues identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
.so-Segmente nur 4KB-seitig ausgerichtet sind; neuere WebRTC-Binaries liefern 16KB-Alignment und verhindern die Ablehnung.Description
app/build.gradle.ktsundhumanoperator/build.gradle.ktsvonio.getstream:stream-webrtc-android:1.1.1aufio.getstream:stream-webrtc-android:1.3.10; es wurden keine Anwendungslogikdateien geändert.Testing
./gradlew :app:lintDebug :humanoperator:lintDebug(Lint stürzt ab wegen vorhandener Kotlin-Metadata-Inkompatibilität inlitertlm-android:0.10.0, nicht durch diese Änderung verursacht),./gradlew :app:assembleDebug(erfolgreich),./gradlew :app:assembleDebug :humanoperator:assembleDebug(:apperfolgreich;:humanoperatorschlägt fehl wegen fehlenderhumanoperator/google-services.jsonin dieser Umgebung) und mitreadelf -lverifiziert, dass die im APK enthaltenelibjingle_peerconnection_so.sonunAlign 0x4000(16KB) aufweist.Codex Task