Conversation
blvckcoded
left a comment
blvckcoded
left a comment
There was a problem hiding this comment.
Looks good 👍 seems CI is failing for iOS target, not sure if it's related to changes in this PR or random failure. Often rerunning has fixed previous failures for me.
| actual fun readBinaryResource(resourcePath: String): ByteArray { | ||
| val path = resourcePath.substringBeforeLast(".") | ||
| val fileType = resourcePath.substringAfterLast(".") | ||
| println("resourcePath=$resourcePath, path=$path, fileType=$fileType") |
There was a problem hiding this comment.
Although it's just test, probably can remove debug print statements in this file
There was a problem hiding this comment.
I left it for debugging since it is not due to a flaky CI. It is currently not working for iOS / native.
I read there is another gradle task needed to copy the assets into the build directory.
There was a problem hiding this comment.
You mean the copy task from the article or a different one?
There was a problem hiding this comment.
Yes, I think I haven't added it already.
|
what is the status of this pr? |
4 participants
📑 What does this PR do?
Load test resources per platform. See this blogpost for implementation details: https://developer.squareup.com/blog/kotlin-multiplatform-shared-test-resources/
✅ Checklist
🧪 How can this PR been tested?
🧾 Tasks Remaining: (List of tasks remaining to be implemented)
🖼️ Screenshots (if applicable):