feat: extract Ed25519 signature verification into reusable middleware#426
Open
devAgatha wants to merge 1 commit into
Open
feat: extract Ed25519 signature verification into reusable middleware#426devAgatha wants to merge 1 commit into
devAgatha wants to merge 1 commit into
Conversation
…AnnabelJoe#268) - Add verifyMeterSignature() and withMeterAuth() in lib/middleware/verifyEd25519.ts - Refactor /api/readings to use the new middleware - Add unit tests for valid/invalid signature and missing meter cases Closes AnnabelJoe#268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the inline Ed25519 signature verification from the readings route handler into a reusable
verifyMeterSignature()middleware function.Changes
src/lib/middleware/verifyEd25519.ts— new middleware withverifyMeterSignature(),isErrorResponse(), andwithMeterAuth()HOFsrc/app/api/readings/route.ts— refactored to call middleware instead of inline verify logicsrc/lib/middleware/__tests__/verifyEd25519.test.ts— unit tests covering valid signature, invalid signature, missing meter, and crypto error casesAcceptance Criteria
Closes #268