Refactoring#18
Draft
Anohros wants to merge 21 commits into
Draft
Conversation
…nore, and apply formatting changes
…ions - Update DevIL library paths to point to the x64 directory. - Update FBX SDK library from 2020.3.1 VS2019 (x86) to 2020.3.9 VS2022 (x64). - Update FBX SDK paths to point to the x64 directory. - Update granny2.dll from x86 to x64 (granny2_x64.dll).
- Update granny2.dll references to granny2_x64.dll. - Update granny format to support granny2 x64 and other small improvements.
…s to scene_ and fbx_scene_
…emove using std namespace
…nd remove usage of using namespace
…dable destructors and remove usage of using namespace
…ance mesh export functionality - Renamed Mesh::getRigidVertices() to Mesh::getVertices() for better naming consistency - Updated documentation comments to reflect the change in method name - Enhanced FbxExporterMesh::ExportMeshes() with improved null checks and error handling - Refactored FbxExporterMesh::ExportMesh() with better validation and resource management - Implemented new BindMaterials() method for more robust material binding - Replaced std::map with std::unordered_set for improved performance in material handling - Updated method naming conventions to follow consistent capitalization (ExportMesh, ExportMeshes)
Aligns with the actual usage of std::string.
…xture name combination
… update variable naming
… and update variable naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring roadmap
Milestone 1
Milestone 2
Probably best to handle it in separate PRs: