Add per-depth header highlighting and refactor highlight group configuration#43
Merged
AntonVanAssche merged 1 commit intoJun 19, 2026
Conversation
Owner
|
Hi, #40 has been merged, please rebase your branch to include the |
39a6799 to
fce54e6
Compare
AntonVanAssche
approved these changes
Jun 19, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
highlight_groupsfor header highlightshighlight_groupsvalues:nvim_set_hl()valueThis new highlight group interpretation includes one minor breaking change, which is that setting
fgorbgtonilwill no longer default to"NONE". In the past if bothfgandbgwerenil(the default state), the highlight group would simply be left uninitialized, so to maintain compatibility in this case thetitle,border, andtextdefaults have been changed tonil, which similarly falls back to an undefined group.This implementation is currently dependent on #40, because as part of highlighting the header rows it needs to get the length of the indent, so it knows what column to start the highlighting. To do this is calls
#get_indent(depth), which is a function defined in #40. If #40 is not merged this can be refactored to hard-code(depth - 1) * 2.