Skip to content

feat: harden skill pipeline gates and rename npm package to stylekit-…#4

Merged
AnxForever merged 1 commit into
mainfrom
codex/stylekit-skill-go-live
Feb 25, 2026
Merged

feat: harden skill pipeline gates and rename npm package to stylekit-…#4
AnxForever merged 1 commit into
mainfrom
codex/stylekit-skill-go-live

Conversation

@AnxForever
Copy link
Copy Markdown
Owner

@AnxForever AnxForever commented Feb 25, 2026

…skill

Summary by CodeRabbit

  • New Features

    • Rebranded package from stylekit-style-prompts-skill to stylekit-skill
    • Added site-type routing, animation profiles, and interaction pattern taxonomies
    • Introduced new CLI options: --site-type, --recommendation-mode, --content-depth, --decision-speed
    • Enhanced quality gates with taxonomy and contract validation
  • Documentation

    • Added Go-Live Checklist for release readiness
    • Expanded README with developer verification steps and new options
  • Tests

    • Added comprehensive test coverage for new features and validations

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 25, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3af0aa8 and 0793222.

📒 Files selected for processing (55)
  • .github/workflows/regression-gate.yml
  • .gitignore
  • GO_LIVE_CHECKLIST.md
  • README.md
  • RELEASE.md
  • SKILL.md
  • agents/claude.yaml
  • bin/stylekit-skill.js
  • package.json
  • prompts/expand-animation-profiles.md
  • prompts/expand-interaction-patterns.md
  • pyproject.toml
  • references/github-actions-regression-gate.yml
  • references/output-contract.md
  • references/taxonomy/animation-profiles.v2.json
  • references/taxonomy/interaction-patterns.v2.json
  • references/taxonomy/site-type-routing.json
  • references/taxonomy/style-tag-map.v2.json
  • references/taxonomy/style-tag-registry.json
  • references/taxonomy/tag-aliases.json
  • references/taxonomy/tag-schema.json
  • scripts/_brief_constants.py
  • scripts/_common.py
  • scripts/audit_style_rule_conflicts.py
  • scripts/blend_engine.py
  • scripts/brief_builder.py
  • scripts/generate_brief.py
  • scripts/merge_taxonomy_expansion.py
  • scripts/prompt_generator.py
  • scripts/propose_upgrade.py
  • scripts/qa_prompt.py
  • scripts/reference_handler.py
  • scripts/review_upgrade_candidate.py
  • scripts/run_pipeline.py
  • scripts/search_stylekit.py
  • scripts/smoke_test.py
  • scripts/v2_taxonomy.py
  • scripts/validate_output_contract_sync.py
  • scripts/validate_taxonomy.py
  • tests/__init__.py
  • tests/conftest.py
  • tests/schemas/benchmark_pipeline_output.json
  • tests/schemas/generate_brief_output.json
  • tests/schemas/qa_prompt_output.json
  • tests/schemas/run_pipeline_codegen_output.json
  • tests/schemas/run_pipeline_manual_output.json
  • tests/schemas/search_stylekit_output.json
  • tests/test_blend_engine.py
  • tests/test_brief_builder.py
  • tests/test_common.py
  • tests/test_output_contracts.py
  • tests/test_qa_prompt.py
  • tests/test_v2_taxonomy.py
  • tests/test_validate_output_contract_sync.py
  • tests/test_validate_taxonomy.py

📝 Walkthrough

Walkthrough

This PR introduces a comprehensive v2 taxonomy system for StyleKit with site-type routing, animation profiles, and interaction patterns. The package is rebranded from "stylekit-style-prompts-skill" to "stylekit-skill". Major additions include expanded Python scripts for brief generation and pipeline orchestration, validation gates for taxonomy and output contracts, upgrade proposal workflows, a new agent configuration, and extensive test coverage with JSON schemas. CI/CD workflows are enhanced with new validation steps.

Changes

Cohort / File(s) Summary
Package Metadata & Rebranding
package.json, bin/stylekit-skill.js
Package name, version, and CLI executable updated; new npm scripts added (doctor, smoke, test:unit, test:slow, check:taxonomy, check:contract, check:gate, prepublishOnly); new homepage and repository URLs; Python version requirement (>=3.10) introduced.
Documentation & Checklists
README.md, RELEASE.md, SKILL.md, GO_LIVE_CHECKLIST.md, prompts/expand-*.md
README rebranded with new CLI references; expanded developer guidance and validation steps; RELEASE and SKILL sections updated with new gate details; new go-live checklist added; new prompt templates for expanding animation and interaction pattern taxonomies.
CI/CD Workflows
.github/workflows/regression-gate.yml, references/github-actions-regression-gate.yml
New CI steps: Node 18 setup, environment info, test dependencies (pytest, jsonschema); separate unit and contract test runs; new taxonomy and output-contract sync guards; updated benchmark regression paths.
V2 Taxonomy System
references/taxonomy/*.json (8 new files)
New JSON taxonomies: tag-schema.v2, site-type-routing, style-tag-map.v2, animation-profiles.v2, interaction-patterns.v2, style-tag-registry, tag-aliases; schemaVersion 2.0.0 across all; defines layouts, motion, interaction patterns, and style mappings per site type.
Output Contract & Validation
references/output-contract.md, tests/schemas/*
Enhanced output-contract with new fields (site_profile, tag_bundle, composition_plan, decision_flow, content_plan); 6 new JSON schemas for validating outputs of generate_brief, run_pipeline (codegen/manual), qa_prompt, search_stylekit, benchmark.
Core Python Scripts - Pipeline
scripts/generate_brief.py, scripts/run_pipeline.py, scripts/search_stylekit.py
Major refactors: generate_brief now modular with run() function supporting site-type, recommendation-mode, content-depth, decision-speed; run_pipeline expanded with decision matrix, scorecard, and AI iteration prompts; search_stylekit integrates site-type routing and v2 taxonomy lookups.
Python Utilities & Helpers
scripts/_common.py, scripts/_brief_constants.py, scripts/blend_engine.py, scripts/brief_builder.py, scripts/prompt_generator.py, scripts/reference_handler.py
New modules providing: common text/JSON utilities (load_json, normalize_text, tokenize, now_iso); design constants and heuristics; style blending with scoring functions; brief construction with visual direction and component guidelines; prompt generation with localization; reference payload handling with schema validation.
Validation & Quality Gates
scripts/validate_taxonomy.py, scripts/validate_output_contract_sync.py, scripts/qa_prompt.py
New validate_taxonomy checks style-tag-map coverage, animation/interaction profiles, and style-tag-registry; validate_output_contract_sync parses contract markdown and validates JSON blocks against schemas; qa_prompt refactored with run() function and enhanced checks (conflict, language, component coverage).
Taxonomy & Upgrade Management
scripts/merge_taxonomy_expansion.py, scripts/propose_upgrade.py, scripts/review_upgrade_candidate.py
New merge_taxonomy_expansion merges Gemini-generated taxonomy updates; propose_upgrade constructs v2 upgrade proposals from pipeline output; review_upgrade_candidate validates upgrade JSON and emits reports; all support dry-run and validation modes.
v2 Taxonomy Engine
scripts/v2_taxonomy.py
New comprehensive module: loads/merges taxonomy references; resolves site types via heuristic matching; computes tag bundles (visual_style, layout_archetype, motion_profile, interaction_pattern, modifiers); builds composition plans, decision flows, and content plans per site type; generates upgrade candidates; ~800 lines of complex interdependent logic.
Smoke & Integration Tests
scripts/smoke_test.py
Expanded to exercise upgrade proposal flow, taxonomy/contract validation, negative test scenarios, and parametrized payloads; validates brief schema; adds metrics and coverage flags to results.
Test Suite
tests/conftest.py, tests/test_*.py (9 new modules)
New fixtures loading taxonomy and style data; comprehensive unit tests for blend_engine, brief_builder, common utilities, v2_taxonomy, qa_prompt, and validate scripts; contract tests validating CLI outputs against JSON schemas (marked as slow); 2100+ lines of test coverage.
Configuration & Dependencies
pyproject.toml, .gitignore, agents/claude.yaml
New pyproject.toml with setuptools build config, pytest settings, and schemaVersion 2.0.0 marking; .gitignore extended for node_modules, pytest_cache, tarballs; new agents/claude.yaml defines StyleKit agent with command templates (one_shot, codegen, search, brief, qa) and error handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SearchStylekit as search_stylekit.py
    participant GenerateBrief as generate_brief.py
    participant V2Taxonomy as v2_taxonomy.py
    participant RunPipeline as run_pipeline.py
    participant QAPrompt as qa_prompt.py

    User->>SearchStylekit: query + site_type
    SearchStylekit->>V2Taxonomy: load_v2_references()
    V2Taxonomy-->>SearchStylekit: taxonomy data
    SearchStylekit->>V2Taxonomy: resolve_site_type()
    V2Taxonomy-->>SearchStylekit: site_type + route
    SearchStylekit->>SearchStylekit: rank styles + apply routing
    SearchStylekit-->>User: candidates + site_profile

    User->>GenerateBrief: query + style + site_type
    GenerateBrief->>V2Taxonomy: load_v2_references()
    V2Taxonomy-->>GenerateBrief: taxonomy + routing data
    GenerateBrief->>GenerateBrief: build_tag_bundle()
    GenerateBrief->>GenerateBrief: build_composition_plan()
    GenerateBrief-->>User: design brief + prompts

    User->>RunPipeline: query + stack + workflow
    RunPipeline->>SearchStylekit: search_stylekit.run()
    SearchStylekit-->>RunPipeline: candidates
    RunPipeline->>GenerateBrief: generate_brief.run()
    GenerateBrief-->>RunPipeline: brief payload
    RunPipeline->>RunPipeline: build_decision_matrix()
    RunPipeline->>QAPrompt: qa_prompt.run()
    QAPrompt-->>RunPipeline: QA results
    RunPipeline-->>User: full pipeline output
Loading
sequenceDiagram
    participant User
    participant SmokeTest as smoke_test.py
    participant RunPipeline as run_pipeline.py
    participant ProposeUpgrade as propose_upgrade.py
    participant MergeTaxonomy as merge_taxonomy_expansion.py
    participant ValidateTaxonomy as validate_taxonomy.py

    User->>SmokeTest: Execute test suite
    SmokeTest->>RunPipeline: run pipeline tests
    RunPipeline-->>SmokeTest: pipeline output
    SmokeTest->>ProposeUpgrade: propose_upgrade.py
    ProposeUpgrade->>ProposeUpgrade: build_upgrade_candidates()
    ProposeUpgrade-->>SmokeTest: upgrade proposal
    SmokeTest->>MergeTaxonomy: merge expansion (dry-run)
    MergeTaxonomy->>MergeTaxonomy: validate new profiles/patterns
    MergeTaxonomy-->>SmokeTest: validation results
    SmokeTest->>ValidateTaxonomy: validate_taxonomy.py
    ValidateTaxonomy->>ValidateTaxonomy: check coverage + registries
    ValidateTaxonomy-->>SmokeTest: taxonomy status
    SmokeTest-->>User: aggregated test results
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Poem

🐰 Hops through the v2 taxonomy forest

With site-types routing through the trees,
Animation profiles dance with ease—
Interaction patterns weave so tight,
The upgrade candidates shine so bright! ✨

—signed, The CodeRabbit

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/stylekit-skill-go-live

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AnxForever AnxForever merged commit c5d4222 into main Feb 25, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant