-
Notifications
You must be signed in to change notification settings - Fork 2
vz update conda yml #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughUpdated package version and transformer attributes; conda environment simplified and defaults channel added. Removed two spatial example packages (manifests and R scripts), cleared src/.metadata, and updated .gitignore. Changes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
katieb1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/package.xml`:
- Around line 29-30: The two <transformer> entries use the same
condaEnv="helloworldR.yml" but different condaEnvVersion values (one is 3 and
the other 2); update the condaEnvVersion attribute on the transformer named
"firstModel" (and the other transformer) so both specify the same version (e.g.,
change the one set to "2" to "3"), or add a clear comment/documentation adjacent
to the transformer entries explaining why different versions are intentionally
required; ensure you update the condaEnvVersion attribute values for the
relevant <transformer> elements to keep them consistent or document the reason
for divergence.
| <transformer name="firstModel" displayName="Hello World Spatial 1 (R)" programArguments="model.R" isStochasticTime="True" | ||
| condaEnv="helloworldR.yml" condaEnvVersion="3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
cat -n src/package.xml | head -50
Repository: ApexRMS/helloworldSpatial
Length of output: 2958
🏁 Script executed:
fd -type f \( -name "README*" -o -name "*.md" -o -name "CHANGELOG*" \) | head -20
Repository: ApexRMS/helloworldSpatial
Length of output: 239
🏁 Script executed:
fd -type f \( -name "README*" -o -name "*.md" -o -name "CHANGELOG*" \)
Repository: ApexRMS/helloworldSpatial
Length of output: 239
🏁 Script executed:
find . -maxdepth 2 -iname "readme*" -o -iname "changelog*" -o -iname "*.md" | head -20
Repository: ApexRMS/helloworldSpatial
Length of output: 80
🏁 Script executed:
cat -n README.md
Repository: ApexRMS/helloworldSpatial
Length of output: 666
🏁 Script executed:
rg "condaEnvVersion" --no-heading
Repository: ApexRMS/helloworldSpatial
Length of output: 198
🏁 Script executed:
find . -name "helloworldR.yml" -o -name "helloworldR*"
Repository: ApexRMS/helloworldSpatial
Length of output: 90
🏁 Script executed:
cat -n src/helloworldR.yml
Repository: ApexRMS/helloworldSpatial
Length of output: 254
Align condaEnvVersion between transformers (or document why they differ).
Both transformers point to the same helloworldR.yml but specify different condaEnvVersion values (3 vs 2). If only one environment version exists, the second transformer may fail to resolve its environment. Align both to version 3, or document why the split is necessary.
🤖 Prompt for AI Agents
In `@src/package.xml` around lines 29 - 30, The two <transformer> entries use the
same condaEnv="helloworldR.yml" but different condaEnvVersion values (one is 3
and the other 2); update the condaEnvVersion attribute on the transformer named
"firstModel" (and the other transformer) so both specify the same version (e.g.,
change the one set to "2" to "3"), or add a clear comment/documentation adjacent
to the transformer entries explaining why different versions are intentionally
required; ensure you update the condaEnvVersion attribute values for the
relevant <transformer> elements to keep them consistent or document the reason
for divergence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/model.R`:
- Around line 25-27: The call to datasheet() is invalid: datasheet() does not
accept column nor datasheet parameters and returns a data.frame (not a
SpatRaster), so replace this with either a call to
datasheetSpatRaster(myScenario, name = "helloworldSpatial_InputDatasheet",
column = "InterceptRasterFile") to directly obtain a SpatRaster, or call
datasheet(myScenario, name = "helloworldSpatial_InputDatasheet") to get the file
path column and then pass that path into terra::rast() before calling
app(rasterMap, ...). Ensure you use name = "helloworldSpatial_InputDatasheet"
(not datasheet=) and reference datasheetSpatRaster(), datasheet(),
terra::rast(), and app() when making the fix.

Update conda yml file to include specific versions that work for Linux and windows.
Summary by CodeRabbit
Chores
Removed
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.