Main Fixes#1
Merged
Merged
Conversation
- Drop R2019 from Build.props and solution (minimum is now R2020) - Condition System.Threading.Tasks.Extensions to non-net8.0-windows targets - Remove hardcoded TargetFramework/Nullable/ImplicitUsings from test project (Build.props already sets these per configuration) - Suppress MSB3277 for net47/net48 in tests (FluentAssertions System.Net.Http version conflict is harmless; tests only run under R2025/net8.0) - Add R2020 to CI/CD build matrix; drop spurious 4.8.x from dotnet-version setup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace -c with --configuration in all workflow commands. dotnet restore/build/test no longer accept the -c shorthand in SDK 10 and pass it raw to MSBuild, which rejects it with MSB1001. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove extra subdirectory from project paths: source/Apibim.Revit.Extensions/... -> source/Apibim.Revit.Extensions.csproj tests/Apibim.Revit.Extensions.Tests/... -> tests/Apibim.Revit.Extensions.Tests.csproj - Replace --configuration with -p:Configuration= (MSBuild property syntax) .NET SDK 10 passes flags through to MSBuild verbatim; MSBuild rejects both -c and --configuration, but accepts -p:Configuration= Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Single build-and-test job with matrix revit: [2020..2026] - Build tests project (which pulls source via ProjectReference) - Run tests against the built DLL directly to avoid SDK 10 flag issues - Publish per-version results via dorny/test-reporter - Upload .trx artifact per version Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add icon.png reference to README header - Add PackageIcon and README to NuGet package via csproj Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.