Skip to content

fix: hide the drag handle for the matched text #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
asjqkkkk wants to merge 2 commits into
base: flutter/3_27_4
Choose a base branch
from
Draft

fix: hide the drag handle for the matched text #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6de68ab
fix: hide the drag handle for the matched text
asjqkkkk Apr 17, 2026
22af6cc
fix: avoid update selection in search_service_v3.dart
asjqkkkk Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/src/editor/editor_component/service/selection/mobile_selection_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,11 @@ class _MobileSelectionServiceWidgetState
shiftWithBaseOffset: true,
);

if (node == null || rects == null || rects.isEmpty) {
if (node == null ||
rects == null ||
rects.isEmpty ||
editorState.selectionUpdateReason ==
SelectionUpdateReason.searchHighlight) {
return const SizedBox.shrink();
}

Expand Down
26 changes: 3 additions & 23 deletions lib/src/editor/find_replace_menu/search_service_v3.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,19 +113,10 @@ class SearchServiceV3 {
);

if (matchWrappers.value.isEmpty || unHighlight) {
editorState.updateSelectionWithReason(
null,
reason: SelectionUpdateReason.searchHighlight,
extraInfo: {
selectionExtraInfoDoNotAttachTextService: true,
},
);
} else {
selectedIndex = selectedIndex;
_highlightCurrentMatch(
pattern,
);
return;
}
selectedIndex = selectedIndex;
_highlightCurrentMatch(pattern);
}

List<MatchWrapper> _getMatchWrappers({
Expand Down Expand Up @@ -160,17 +151,6 @@ class SearchServiceV3 {
if (jumpInterceptor?.call(path) == false) {
editorState.scrollService?.jumpTo(path.first);
}

editorState.updateSelectionWithReason(
selection,
reason: SelectionUpdateReason.searchHighlight,
extraInfo: {
selectionExtraInfoDisableToolbar: true,
selectionExtraInfoDoNotAttachTextService: true,
selectionExtraInfoDisableMobileToolbarKey: true,
selectionExtraInfoSelectionRadius: 6.0,
},
);
}

/// This method takes in a boolean parameter moveUp, if set to true,
Expand Down
Loading