fix: stop mobile selection handles from collapsing selection on tap#1200
Merged
Conversation
Wrap the left/right drag handle in a dedicated _SelectionDragHandle that fills the outer touch rect with its own RawGestureDetector, owns the pan recognizer, and registers a no-op tap recognizer so it wins the gesture arena over the editor's tap recognizer below. This stops a finger lift on the handle from collapsing the selection back to a caret. Also expand the handle's hit area to the platform minimum touch target (44pt iOS / 48dp Android), anchoring growth away from the visible ball so the ball position is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the left/right drag handle in a dedicated _SelectionDragHandle that fills the outer touch rect with its own RawGestureDetector, owns the pan recognizer, and registers a no-op tap recognizer so it wins the gesture arena over the editor's tap recognizer below. This stops a finger lift on the handle from collapsing the selection back to a caret.
Also expand the handle's hit area to the platform minimum touch target (44pt iOS / 48dp Android), anchoring growth away from the visible ball so the ball position is unchanged.