fix: preserve node identity during type updates#1201
Closed
appflowy wants to merge 1 commit into
Closed
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve editor node identity during safe block type conversions.
Changes:
UpdateNodeTypeOperationfor same-node type/data updates.Transaction.updateNodeTypeandDocument.updateNodeType.Node.copyWithwhen explicitly requested.diffDocumentsand apply them inEditorState.Why
The previous markdown conversion path replaced a block with insert+delete. That regenerated block ids and related child/text references even when only the block type changed. Desktop and web now rely on same-id type updates to avoid shared block reference corruption.
Verification
dart format --output=none --set-exit-if-changed ...flutter test test/core/transform/operation_test.dart test/core/document/diff_test.dart test/core/document/node_test.dart, but this machine has Flutter 3.27.4 while this package requires Flutter >=3.32.0.