Skip to content

add CI build safe compile flags. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericcanton wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add CI build safe compile flags. #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7885b5f
add CI build safe compile flags.
ericcanton Jun 17, 2026
7f7acbf
Merge branch 'main' into ci_build_flags
ericcanton Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,16 @@ endif()

# Compiler-specific optimizations
# Note: -ffast-math is intentionally omitted — it breaks FINUFFT (IEEE-754 violations)
# CI runners use x86-64-v3 (AVX2) for portability; local builds use native.
if(DEFINED ENV{CI} AND "$ENV{CI}" STREQUAL "true")
set(MARCH_FLAG "-march=x86-64-v3")
else()
set(MARCH_FLAG "-march=native -mtune=native")
endif()
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
set(CMAKE_CXX_FLAGS_RELEASE "-O3 -march=native -mtune=native")
set(CMAKE_CXX_FLAGS_RELEASE "-O3 ${MARCH_FLAG}")
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
set(CMAKE_CXX_FLAGS_RELEASE "-O3 -march=native -mtune=native")
set(CMAKE_CXX_FLAGS_RELEASE "-O3 ${MARCH_FLAG}")
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
set(CMAKE_CXX_FLAGS_RELEASE "/O2 /arch:AVX2")
endif()
Expand Down
8 changes: 6 additions & 2 deletions senpy/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@ project(senpy)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

# Add optimization flags
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3 -march=native")
# Add optimization flags; CI runners use x86-64-v3 (AVX2) for portability.
if(DEFINED ENV{CI} AND "$ENV{CI}" STREQUAL "true")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3 -march=x86-64-v3")
else()
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3 -march=native")
endif()

# add ../cpp relative to this CMakeLists.txt
set(CPP_DIR "${CMAKE_CURRENT_LIST_DIR}/../src")
Expand Down
2 changes: 1 addition & 1 deletion senpy/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def _copy_runtime_libraries(self):
sources=sources,
include_dirs=include_dirs,
language='c++',
extra_compile_args=['-std=c++17', '-O3', '-march=native', '-DPYTHON'],
extra_compile_args=['-std=c++17', '-O3', '-march=x86-64-v3' if os.environ.get('CI') == 'true' else '-march=native', '-DPYTHON'],
extra_link_args=[
f'-L{finufft_lib_dir}',
'-lfinufft',
Expand Down
Loading