Fix inherited method being written twice inside generated ViewState when using modifiers#259
Open
bejibx wants to merge 5 commits intoArello-Mobile:developfrom
Open
Fix inherited method being written twice inside generated ViewState when using modifiers#259bejibx wants to merge 5 commits intoArello-Mobile:developfrom
bejibx wants to merge 5 commits intoArello-Mobile:developfrom
Conversation
This was referenced Jul 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest version of Moxy (1.5.6) compare interface methods with superclass methods using
TypeSpec#equal(Object), which leads to methods not being equal when we rename parameter in overriden method or add modifier to it (finalfor example). This leads to those methods are generated multiple times insideViewStatewhich breaks build. I change this logic to compare methods only be name and parameter types sequentially.