Skip to content

[codex] Extract session broker surfaces#100

Draft
Arenukvern wants to merge 11 commits into
mainfrom
codex/session-broker
Draft

[codex] Extract session broker surfaces#100
Arenukvern wants to merge 11 commits into
mainfrom
codex/session-broker

Conversation

@Arenukvern

@Arenukvern Arenukvern commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • Moves the session/persistence ownership toward IntentCall-backed session surfaces and removes stale local session-manager/persistence copies from mcp_server_dart.
  • Integrates the published hosted IntentCall packages from pub.dev and removes the temporary git dependency overrides.
  • Normalizes dynamic registry and command result mapping so the server side can consume IntentCall-shaped results without private/internal duplication.
  • Hardens runtime commandability: semantic snapshots expose viewport visibility, offscreen taps fail honestly, reveal/search reports tappability, and the exec sweep refreshes visible refs before interactions.
  • Improves desktop-window capture diagnostics and validate-runtime fallback reporting so missing host context and helper retry details are visible instead of flattened into a generic screenshot failure.

Why

Downstream tools need a reusable realtime broker/session foundation without importing Flutter-VM-shaped internals. This keeps Flutter-specific VM service, screenshots, and extension calls as adapters while consuming the shared session/result/registration surfaces through published IntentCall packages.

Validation

  • flutter pub get resolves intentcall_core, intentcall_mcp, and intentcall_session from hosted https://pub.dev.
  • dart analyze packages/server_capability_kernel packages/server_capability_core mcp_server_dart mcp_toolkit
  • flutter test test/control_flow_service_test.dart test/agent_entry_helpers_test.dart test/mcp_toolkit_bootstrap_test.dart test/semantic_snapshot_surface_test.dart from mcp_toolkit
  • dart test mcp_server_dart/test/core_executor_test.dart mcp_server_dart/test/dynamic_registry_input_schema_test.dart mcp_server_dart/test/registry_discovery_service_test.dart mcp_server_dart/test/session_manager_test.dart mcp_server_dart/test/command_snapshot_service_test.dart mcp_server_dart/test/desktop_capture_recovery_test.dart mcp_server_dart/test/platform_view_capture_flow_test.dart mcp_server_dart/test/desktop_window_screenshot_test.dart
  • dart test packages/server_capability_kernel/test packages/server_capability_core/test mcp_server_dart/test/agent_registry_host_test.dart mcp_server_dart/test/host_test.dart mcp_server_dart/test/host_extras_test.dart mcp_server_dart/test/flutter_inspector_resources_test.dart
  • Live validate-runtime without global desktop flags: ok:true, verdict:pass_with_fallback, failure details now report missing_flutter_device.
  • Live validate-runtime with --flutter-device macos --flutter-project-dir flutter_test_app: ok:true, verdict:pass, captureMode:desktop_window, no fallback.
  • Live scripts/run_exec_sweep.sh: PASS=35 FAIL=0 SKIP=0.
  • steward probe --json --profile quick
  • git diff --check

Notes

GitNexus change detection originally reported CRITICAL for the branch because the PR intentionally touches the broader session/broker/dynamic-registry flow. The hosted-package integration itself reports low risk in change detection; the shim impact is medium because it feeds the capability-kernel public surface and is covered by capability/host registration tests.

@docs-page

docs-page Bot commented Jun 22, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/arenukvern/mcp_flutter~100

Documentation is deployed and generated using docs.page

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3e298004-5afe-48de-8d85-6995b8746ffb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/session-broker

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

# Conflicts:
#	packages/server_capability_core/pubspec.yaml
#	packages/server_capability_kernel/pubspec.yaml
@Arenukvern Arenukvern self-assigned this Jun 24, 2026
- Adjusted project indexing in AGENTS.md to reflect updated symbol and relationship counts.
- Updated CHANGELOG.md to document breaking changes in `flutter_mcp_core.dart` and the migration of canonical types to `intentcall_core`.
- Added a new command in steward.yaml to check for stale local or root path dependencies in hosted IntentCall.
- Updated README.md to reflect the new consumer package policy for IntentCall version 0.2.1.
- Enhanced the gesture interaction service to handle web-specific scrolling actions and added new utility functions for semantic snapshot services.
- Improved tests for registry discovery and semantic snapshot functionalities.
- Cleaned up legacy artifacts in the exec sweep script and ensured proper version checks for IntentCall dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant