Remove Faraday connection authorization warnings#117
Remove Faraday connection authorization warnings#117rickychilcott wants to merge 1 commit intoAsana:masterfrom
Conversation
|
@hieubui149 : 👋 Hi there! If you all are looking at PRs, can I point you towards #112 #113 and #114? They've been hanging out for a while. |
|
Hello @rickychilcott, I am not the owner of this repo so I can't help you to merge this PR. I faced the same issue and it's floody spamming my logs. In order to get through it, I did monkey patching this class and it works just fine. Thank you! |
|
Applying this as a monkey patch worked for me. Thanks @hieubui149. |
|
@JW-Asana Hi! May we have this merged? There is too much warning spamming... |
|
Hi! This PR does not fix the faraday warning when using acces_token authentication. I have faced the problem today and this is how I fixed it. Would be nice to integrate it to the PR ? module Asana
module Authentication
module OAuth2
class AccessTokenAuthentication
#... snip
def configure(connection)
@token = @token.refresh! if @token.expired?
connection.params[:access_token] = @token.token
connection.request :oauth2, { token_type: :param, param_name: 'access_token' }
end
#... snip
end
end
end
end |
|
It's really priority, because I can't use CLI application, because of warnings |
|
I’ll close. |
Based on my read of https://lostisland.github.io/faraday/middleware/authentication, this should work fine in Faraday 1 and 2
Close #116