Skip to content

Lazy load reown #13555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dylanjeffers wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Lazy load reown #13555

dylanjeffers wants to merge 1 commit into from

Conversation

@dylanjeffers
Copy link
Contributor

@dylanjeffers dylanjeffers commented Jan 6, 2026 •
edited
Loading

Lazy loads reown modules which quite large (5% of main bundle). Need to test this on RC, likely will have an issue.

@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6c02b23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

raymondjacobson
raymondjacobson reviewed Jan 6, 2026
View reviewed changes
packages/web/test-reown-lazy-load.md Outdated
@@ -0,0 +1,35 @@
# Testing Reown Lazy Loading
Copy link
Member

@raymondjacobson raymondjacobson Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentionally comitted?

Copy link
Contributor Author

@dylanjeffers dylanjeffers Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

raymondjacobson
raymondjacobson reviewed Jan 6, 2026
View reviewed changes
Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is a bit scary to me. you really think this is worth it for the 5%? @rickyrombo wdyt?

@dylanjeffers
Copy link
Contributor Author

dylanjeffers commented Jan 6, 2026

this PR is a bit scary to me. you really think this is worth it for the 5%? @rickyrombo wdyt?

I also agree this is potentially overkill

raymondjacobson
raymondjacobson approved these changes Jan 6, 2026
View reviewed changes
Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as we test, i'm okay w/ merge

rickyrombo
rickyrombo reviewed Jan 6, 2026
View reviewed changes
Copy link
Contributor

@rickyrombo rickyrombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One side effect of this is "sign in with" (currently only metamask) will not auto connect and have you signed in, right?

Also I agree this might not be worth the risk... But it is annoying how these third parties keep gumming up our bundle size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickyrombo rickyrombo rickyrombo left review comments

@raymondjacobson raymondjacobson raymondjacobson approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dylanjeffers @raymondjacobson @rickyrombo