-
Notifications
You must be signed in to change notification settings - Fork 125
Feature: Upload via TUS #13574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature: Upload via TUS #13574
Conversation
… for compatibility issue
…initions - use api version
…reorders, and update upload success to only need id. cleanup unused redux things
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11648676 | Triggered | Generic High Entropy Secret | fe50394 | dev-tools/environment/openaudio-1.env | View secret |
| 11648678 | Triggered | Generic High Entropy Secret | fe50394 | dev-tools/environment/openaudio-3.env | View secret |
| 11648679 | Triggered | Generic High Entropy Secret | fe50394 | dev-tools/environment/openaudio-4.env | View secret |
| 11648680 | Triggered | Generic High Entropy Secret | fe50394 | dev-tools/environment/openaudio-2.env | View secret |
| 24672057 | Triggered | Generic Private Key | fe50394 | dev-tools/tls/key.pem | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
| ) | ||
| } | ||
|
|
||
| async uploadFileV2({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can just be specific and call it uploadFileTus or something
- Adds support for stems to the new TUS-based upload flow. - Adds new `publishTrack` SDK API that only maps existing upload responses to metadata and writes to chain - Removes superfluous logic in UploadPage that does the above - Refactors UploadPage to do the upload via a promise ref so that the control flow is simpler to follow
…ew TUS uploads (#13582) - Moves more logic into the mutation query hooks to simplify calls - Parallelize the track/stem uploading - Add amplitude events to mirror existing sagas - Add sentry error logging - Add support for ReactNative files
<img width="1192" height="470" alt="image" src="https://github.com/user-attachments/assets/edc084bf-d8cd-419d-b9d5-d08d1b9d3277" /> - Adds status of stems to the finish page - Fixes reporting status of images - Fixes reporting individual stem errors - Fixes uploading images (use CID!) - Publish parent tracks and stems at the same time
WIP: Will use this branch as the "feature branch".
See commit messages and watch for PRs with this as the base.
If something isn't obviously related to the upload feature, it's probably some changes I needed to get local stack up.
New upload approach:
Note: We could get even more "wins" here by having images start uploading immediately after being selected, but I decided against that for now to keep things sane.
Potential future work that I decided against in the end:
Unorganized summary of seemingly unrelated changes:
mutationOptionsfor better mutation types