Skip to content

Conversation

@raymondjacobson
Copy link
Member

Issue was when fetching from mirrors, we threw away the attached onEnd callback. This has been broken for a while, but because of recent content shuffling is much much more noticeable.

This logic all sucks can we please burn it to the ground.

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2026

⚠️ No Changeset found

Latest commit: 4255df6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow subtle, nice work

@raymondjacobson raymondjacobson merged commit 53d111a into main Jan 15, 2026
13 checks passed
@raymondjacobson raymondjacobson deleted the rj-player-fix branch January 15, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants