Feature to add a filtering options on the API call#145
Feature to add a filtering options on the API call#145Nevsksar wants to merge 4 commits intoAutoIDM:mainfrom
Conversation
tap_clickup/tap.py
Outdated
There was a problem hiding this comment.
This should be an ArrayType see https://sdk.meltano.com/en/latest/classes/typing/singer_sdk.typing.ArrayType.html
tap_clickup/streams.py
Outdated
There was a problem hiding this comment.
Params should be handled via https://sdk.meltano.com/en/latest/classes/singer_sdk.RESTStream.html#singer_sdk.RESTStream.get_url_params
tap_clickup/streams.py
Outdated
There was a problem hiding this comment.
Did they add a new concept of workteamid? Or workspace_id, could you link to that in clickups docs?
There was a problem hiding this comment.
So the structure is Workspace>Space>Folder>List>Task>Subtask
In the app/platform they are called workspaces, but for the API they are called Teams, also there is a feature called "teams" (that group users together) but in the API they call it "group"
https://clickup.com/api/clickupreference/operation/CreateTeam/
tap_clickup/streams.py
Outdated
There was a problem hiding this comment.
All of this needs to go away. Please go through the getting started for Meltano, and read through how singer works.
Adding extra fields to a config block added here https://github.com/AutoIDM/tap-clickup/blob/main/meltano.yml#L6 will pass all of the configs via the config CLI argument (via a json file) to the tap. This is all handled by the config options you altered in tap.py below
tap_clickup/streams.py
Outdated
tap_clickup/tap.py
Outdated
tap_clickup/tap.py
Outdated
|
|
||
| name = "task" | ||
| # Date_updated_gt is greater than or equal to not just greater than | ||
| path = "/team/{team_id}/task" |
There was a problem hiding this comment.
All changes from line 0 to line 50 need to go away
Addresses the requests to merge the PR AutoIDM#145

Description
When dealing with enterprise workspaces in ClickUp, as ClickUp admins, we often find ourselves having access to multiple workspaces, lists, tasks, and other elements that are not needed in our pipeline. To save resources, processing time, and improve efficiency, it is beneficial for us to have the ability to filter specific elements that we want to fetch.
Noteworthy ClickUp API Bugs
During the development of this project, I encountered some inherent bugs in ClickUp's API. Primarily, these bugs prevented the passing of a single space or list as a parameter. However, a workaround was discovered: by passing the same ID twice, the API would function correctly, and there are not any duplicate values in the API response.
Issues
For example, when using the command meltano --environment=dev run tap-clickup ..., the configurations are not being applied as expected from the dev envv because it reads only from the common configurations.
Taking this meltano.yml sample, the code always reads "spaces_id" as '90100424497' even when we run it in prod (which in this case should be '90070255202'