Add dissemination readiness check: structured warnings before final approve#15
Open
CMander02 wants to merge 1 commit intoziyan-todo-7from
Open
Add dissemination readiness check: structured warnings before final approve#15CMander02 wants to merge 1 commit intoziyan-todo-7from
CMander02 wants to merge 1 commit intoziyan-todo-7from
Conversation
…pprove - Add validate_dissemination_readiness() checking PDF, main.tex, reviews, readiness_report.json - Stage 08 approve now shows readiness warnings and requires 'yes' confirmation - readiness_report.json blocking_gaps are surfaced as warnings to the user - Prompt updated to require readiness_report.json with blocking_gaps/warnings schema - 7 new tests covering all warning scenarios Addresses TODO 8 (V8-1 through V8-2) from vulnerability analysis. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_dissemination_readiness()checking PDF, main.tex, reviews, andreadiness_report.jsonyesconfirmationreadiness_report.jsonblocking gaps are surfaced as warnings to the userreadiness_report.jsonwithblocking_gaps/warningsschemaContext
Example run's Stage 08 identified 4 blocking gaps (missing baselines, missing splits, abstract too long, no figure scripts) but the user could approve without any warning. The system now surfaces these as structured warnings before final approval.
Depends on #14.
Test plan
tests/test_dissemination.py— all passing--fake-operatorfull run → Stage 08 approve → verify warning display🤖 Generated with Claude Code