Skip to content

Allow 3rd-party plugins to use custom views and controllers #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r-a-y wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Allow 3rd-party plugins to use custom views and controllers #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions class.mexp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,11 +210,18 @@ public function action_enqueue_media() {

$tabs = apply_filters( 'mexp_tabs', array() );
$labels = apply_filters( 'mexp_labels', array() );
$js = apply_filters( "mexp_js_{$service_id}", array(
'item' => 'media.view.MEXPItem',
'toolbar' => 'media.view.Toolbar.MEXP',
'view' => 'media.view.MEXP',
'controller' => 'media.controller.MEXP'
) );

$mexp['services'][$service_id] = array(
'id' => $service_id,
'labels' => $labels[$service_id],
'tabs' => $tabs[$service_id],
'js' => $js
);
}

Expand Down
33 changes: 29 additions & 4 deletions js/mexp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,9 @@ media.view.MEXP = media.View.extend({

renderItem : function( model ) {

var view = new media.view.MEXPItem({
var item = stringToFunction( this.service.js.item );

var view = new item({
model : model,
service : this.service,
tab : this.tab
Expand Down Expand Up @@ -458,8 +460,10 @@ media.view.MediaFrame.Post = post_frame.extend({

}

var mexpController = stringToFunction( service.js.controller );

this.states.add([
new media.controller.MEXP( controller )
new mexpController( controller )
]);

// Tabs
Expand Down Expand Up @@ -504,8 +508,9 @@ media.view.MediaFrame.Post = post_frame.extend({
mexpContentRender : function( service, tab ) {

/* called when a tab becomes active */
var view = stringToFunction( service.js.view );

this.content.set( new media.view.MEXP( {
this.content.set( new view( {
service : service,
controller : this,
model : this.state().props.get( tab ),
Expand All @@ -516,8 +521,11 @@ media.view.MediaFrame.Post = post_frame.extend({
},

mexpToolbarCreate : function( toolbar ) {
var serviceId = this.state().id.replace( 'mexp-service-', '' ),
viewId = mexp['services'][serviceId]['js']['toolbar'],
view = stringToFunction( viewId );

toolbar.view = new media.view.Toolbar.MEXP( {
toolbar.view = new view( {
controller : this
} );

Expand Down Expand Up @@ -580,3 +588,20 @@ media.controller.MEXP = media.controller.State.extend({
}

});

// Instantiate a javascript object using a string.
// @link http://stackoverflow.com/a/2441972
var stringToFunction = function( str ) {
var arr = str.split( "." );

var fn = ( window || this );
for ( var i = 0, len = arr.length; i < len; i++ ) {
fn = fn[arr[i]];
}

if ( typeof fn !== "function" ) {
throw new Error( "function not found" );
}

return fn;
};