Make DB_NAME constants removal logic language-agnostic#2822
Open
Make DB_NAME constants removal logic language-agnostic#2822
Conversation
Replace exact string matching with a regex that is strict on PHP define() calls (only matches default values from wp-config-sample.php) but flexible with comments, so translated wp-config.php files are handled correctly.
…db_name-constants-more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude assisted with the regex implementation and test cases. All code was reviewed.
Proposed Changes
define()calls (only matches exact default values from wp-config-sample.php) but flexible with comments, so translated wp-config.php files are handled correctlyTesting Instructions
Run
npm startCreate a new site
Confirm wp-config.php doesn't have DB_* constants
In the same site, copy the content from wp-config-sample.php and paste it to wp-config.php, modify the any comment.
Go to the export tab and export the entire site.
Confirm the DB_* constants are removed.
In the same site, copy the content from wp-config-sample.php and paste it to wp-config.php, modify the any value.
Go to the export tab and export the entire site.
Confirm the all the DB_* constants are kept
Run
npm test -- tools/common/lib/tests/remove-default-db-constants.test.tsVerify all tests pass, including the new ones for translated comments
Pre-merge Checklist