Conversation
- Add enablePhpMyAdmin field to siteDetailsSchema and ipc-types.d.ts - Add DEFAULT_ENABLE_PHPMYADMIN = false constant for easy toggling - Add enablePhpMyAdmin to ServerConfig IPC type - Pass enablePhpMyAdmin from site data through to RunCLI args (phpmyadmin: true) - Add phpmyadminChanged to SiteSettingChanges and siteNeedsRestart
- Add --phpmyadmin / --no-phpmyadmin to CLI site set command - Persist enablePhpMyAdmin in appdata via site set - Add phpmyadmin to EditSiteOptions and buildCliArgs - Detect enablePhpMyAdmin changes in updateSite IPC handler
- Add Enable phpMyAdmin checkbox in Edit Site → Debugging tab - Checkbox is disabled with offline tooltip when user has no internet - Add phpMyAdmin button to Open in… section on Overview tab - Button only shown when phpMyAdmin is enabled for the site - Button is disabled with offline tooltip when user has no internet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
I planned the feature architecture - data model, CLI flags, server config propagation, UI placement, offline handling, and persistence. Implementation was carried out by Claude (Sonnet 4.6) following that plan step by step.
Proposed Changes
Adds per-site phpMyAdmin support using the
--phpmyadminflag already available in@wp-playground/cli:@wp-playground/cli@3.1.12removing the--phpmyadmin requires SQLiteguard (see below)site set --phpmyadmin / --no-phpmyadminflag to persist the settingA
DEFAULT_ENABLE_PHPMYADMIN = falseconstant intools/common/constants.tsmakes it easy to flip the default on for all new sites.Known Issues
The PR includes two patches for Playground packages.
The first
patch-packagepatch in this PR removes the--skip-sqlite-setupguard that previously prevented even getting this far - that guard was overly broad and blocked Studio's use case entirely. This also should be fixed upstream.The second one fixes the path to the SQLite plugin hardcoded in the Playground CLI shim. The Playground CLI bundles phpMyAdmin and injects a SQLite-to-MySQL compatibility shim, but the path it hardcodes (
/internal/shared/sqlite-database-integration/wp-pdo-mysql-on-sqlite.php) doesn't match where Studio mounts the SQLite integration. This is a bug in@wp-playground/clithat needs to be fixed upstream before this feature can ship.Without that patch, phpMyAdmin loads but immediately crashes with:
Testing Instructions
npm run cli:buildPre-merge Checklist