Skip to content

Add happychat client npm package to mobile chat page#23856

Closed
unDemian wants to merge 7 commits into
fix/route-mismatchfrom
add/happychat-client-to-mobile
Closed

Add happychat client npm package to mobile chat page#23856
unDemian wants to merge 7 commits into
fix/route-mismatchfrom
add/happychat-client-to-mobile

Conversation

@unDemian
Copy link
Copy Markdown
Contributor

@unDemian unDemian commented Apr 3, 2018

Built on top of #23842

Summary

This PR uses the in-development happychat-client npm package to replace the happychat entry point used for mobile user at the route me/chat

This will not be merged until we publish the npm package

Testing

  1. Make sure you use the same npm version for both projects
  2. Switch happychat-client branch to add/layout-option Add layout option happychat-client#196
  3. npm link in happychat-client
  4. npm link happychat-client in calypso
  5. Run npm run dev:npm in happychat-client and leave it running
  6. Start calypso
  7. Access /me/chat chat should be loaded and it should work properly

@unDemian unDemian self-assigned this Apr 3, 2018
@matticbot
Copy link
Copy Markdown
Contributor

@unDemian unDemian changed the base branch from master to fix/route-mismatch April 3, 2018 14:27
@unDemian unDemian added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Apr 3, 2018
@unDemian unDemian requested a review from a team April 3, 2018 15:09
@unDemian unDemian added [Status] In Progress and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 5, 2018
@unDemian unDemian requested review from a team and removed request for a team April 5, 2018 09:35
@unDemian unDemian added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Apr 5, 2018
@unDemian unDemian mentioned this pull request Apr 10, 2018
@unDemian unDemian force-pushed the fix/route-mismatch branch from 388720a to ccba066 Compare April 11, 2018 11:43
@unDemian unDemian force-pushed the add/happychat-client-to-mobile branch from 41948f4 to 8fe62fa Compare April 11, 2018 11:47
@kwight
Copy link
Copy Markdown
Contributor

kwight commented Apr 17, 2018

For those testing, it looks like happychat-client needs Node 6.11.5, while Calypso needs Node 8.11.0 to get everything to start. You don't need the happychat repo or Redis running at all.

Following the instructions, I have a chat interface of sorts showing up in /me/chat, with some content from previous testing, but I'm not sure what to expect of the interface (mine is all unstyled):

screen shot 2018-04-17 at 12 44 20 pm

@unDemian
Copy link
Copy Markdown
Contributor Author

Thanks for taking the time.

Following the instructions, I have a chat interface of sorts showing up in /me/chat, with some content from previous testing, but I'm not sure what to expect of the interface (mine is all unstyled):

The styles are served by the happychat-client development process, in order to have it working you should run npm run dev:npm (step 4 in description) in the happychat-client and let it running so the http server that serves the styles is running. I updated the description to include that.

@unDemian unDemian requested review from a team and removed request for a team May 10, 2018 11:02
@alisterscott
Copy link
Copy Markdown
Contributor

Is this still required?

@unDemian
Copy link
Copy Markdown
Contributor Author

unDemian commented Aug 6, 2018

Sorry for the late response, I was afk, the Happychat Client Calypso integration was put on hold as our team has other high priority work scheduled. We will most likely come back to this after the GM. So let's keep the PRs around. Thanks

@alisterscott
Copy link
Copy Markdown
Contributor

Closing due to inactivity. Please reopen if necessary.

@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 12, 2018
@lancewillett lancewillett deleted the add/happychat-client-to-mobile branch March 29, 2019 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants