Improve Gradle configuration & Rerun datagen#101
Open
tmvkrpxl0 wants to merge 5 commits into
Open
Conversation
# Conflicts: # src/generated/resources/.cache/8360b56ed49e5e74b2d001f2139fc65c7861c482 # src/generated/resources/.cache/9833d8c585dbb9d02ddaa2f15e4cf4ccb8f5b99f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently installed this mod in my server and noticed datapack error.
It was because cookie dough item is deleted and its advancement is now invalid. I see that there is intention to re-add it back to other mod but considering datagen output is auto generated, if it is not here now, then its output should not include it.
This PR also tweaks some configurations in build.gradle so that:
localRuntimeinstead ofruntimeOnly. It should uselocalRuntimewhen intention is just to include other mod to Minecraft, not depend on it.