Open
Conversation
vmarcella
reviewed
Apr 28, 2025
Member
There was a problem hiding this comment.
This looks good to me, but could you also update our installation script to support aarch64 and x86_64 flags (with x86_64 as the default) and to correctly install either binary using the same process we currently have there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the workflow files to compile and release binaries for both Azure archs, x86-64 but also aarch64. The arm container requires extra dependencies and had problems with compiling with go 1.23 on ubuntu-latest so I had to add 1.24.1 from go's site.
The different release action is to remove deprecation messages from github.