Skip to content

Add FlatFileSchemaGeneration as recognized built-in operation type#8890

Open
anandgmenon wants to merge 3 commits intomainfrom
feature/flatfile-schema-generation-support
Open

Add FlatFileSchemaGeneration as recognized built-in operation type#8890
anandgmenon wants to merge 3 commits intomainfrom
feature/flatfile-schema-generation-support

Conversation

@anandgmenon
Copy link
Contributor

@anandgmenon anandgmenon commented Mar 6, 2026

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

The designer fails to load workflows containing the new FlatFileSchemaGeneration built-in operation. The error:

Operation type 'FlatFileSchemaGeneration' does not support swagger

This happens because the designer doesn't recognize FlatFileSchemaGeneration as a built-in operation type. When it encounters this operation type in a workflow definition, it falls through to the swagger-based API connection resolution path, which doesn't support it.

Impact of Change

  • Users: Workflows containing the FlatFileSchemaGeneration built-in operation will now load in the designer instead of failing with "Operation type 'FlatFileSchemaGeneration' does not support swagger".
  • Developers: Adds a new built-in operation type constant and maps it in the operation manifest. No API contract changes; other code referencing built-in operation detection may now receive this type.
  • System: Minimal runtime impact — just an additional recognized built-in operation; no performance or dependency changes expected.

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in: Standalaon designer

Contributors

Screenshots/Videos

image

Copilot AI review requested due to automatic review settings March 6, 2026 11:34
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: Add FlatFileSchemaGeneration as recognized built-in operation type
  • Issue: Title is clear and descriptive, explains exactly what the change is.
  • Recommendation: Title is fine as-is. If you want a slightly shorter variant you could use: Recognize FlatFileSchemaGeneration as a built-in operation.

Commit Type

  • Properly selected (feature).
  • Only one option is checked which is correct for this change.

Risk Level

  • Selected in body as Low and the PR has the label risk:low — this matches the scope of the change (small additions of constants and manifest mappings).

What & Why

  • Current: The body explains that the designer fails to load workflows containing FlatFileSchemaGeneration with the error: Operation type 'FlatFileSchemaGeneration' does not support swagger and states that the designer didn't recognize it as a built-in operation.
  • Issue: None — this is clear and focused.
  • Recommendation: (Optional) Add a reference to any related issue or ticket number if available.

Impact of Change

  • Impact is described and aligns with the code changes.
  • Recommendation:
    • Users: Workflows that include FlatFileSchemaGeneration will load in the designer instead of failing.
    • Developers: New built-in operation constant and manifest mapping added; call out that code paths that rely on built-in operation detection may now receive this type.
    • System: Minimal. No perf or dependency changes expected.

⚠️ Test Plan

  • Manual testing is indicated and you've included a screenshot and a note that it was tested in the Standalone designer.
  • Assessment: Manual validation is acceptable for this small change, but automated tests would make this change more robust and easier to validate on future refactors.
  • Recommendation: Add at least one unit test covering:
    • The new constant/value is present in the constants files (libs/designer-v2 and libs/designer).
    • The new value is included in supportedBaseManifestTypes and recognized by isBuiltInOperation.
    • The builtInOperationsMetadata includes the mapping for flatfileschemageneration to flatFileSchemaGeneration.
      If adding automated tests is not feasible, add a short explanation why manual testing is sufficient for this change.

⚠️ Contributors

  • Assessment: The Contributors section is blank.
  • Recommendation: Add any reviewers, PMs, or designers who contributed. If there were none, consider adding a brief note acknowledging that (blank is acceptable but it is recommended to credit contributors).

Screenshots/Videos

  • Screenshot provided and appears to demonstrate manual verification.
  • Good to include for visual confirmation of the fix.

Summary Table

Section Status Recommendation
Title Keep as-is or optionally shorten.
Commit Type No change needed.
Risk Level Matches risk:low label.
What & Why Clear; consider linking issue/ticket.
Impact of Change Good coverage.
Test Plan ⚠️ Add unit tests for constants/manifest recognition or justify manual testing.
Contributors ⚠️ Add contributors or a short note.
Screenshots/Videos Screenshot included.

Summary: The PR title and body follow the required template and are largely complete and accurate. The code diff is small (3 files changed, ~11 additions), adding constant entries and a manifest mapping — this is consistent with a low-risk change. The advised risk level is risk:low, which matches the label on the PR.

Action items I recommend before merging (minor):

  • Add unit tests that assert the new built-in op is recognized (isBuiltInOperation) and present in builtInOperationsMetadata.
  • Fix small typo in the Test Plan: Standalaon designer -> Standalone designer.
  • Add contributors (or a note) in the Contributors section if applicable.
  • (Optional) Link any associated issue/bug ticket for traceability.

Please update the PR with the unit tests or a short justification for why automated tests aren't present, fix the minor typo, and add contributors if relevant. Once those are addressed (or explained), this PR is good to merge.


Last updated: Mon, 16 Mar 2026 17:14:35 GMT

@anandgmenon anandgmenon added the risk:low Low risk change with minimal impact label Mar 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support across designer services and both designer UI versions for the new built-in operation type FlatFileSchemaGeneration, preventing the designer from incorrectly treating it as swagger-resolved and failing to load affected workflows.

Changes:

  • Register flatfileschemageneration as a supported built-in/base manifest operation type and map it to the Flat File built-in connector metadata.
  • Add the new operation type constant to Constants.NODE.TYPE in both designer (v1) and designer-v2.
  • Add the new serialized type (FlatFileSchemaGeneration) to Constants.SERIALIZED_TYPE in both designer (v1) and designer-v2.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
libs/logic-apps-shared/src/designer-client-services/lib/base/operationmanifest.ts Recognizes flatfileschemageneration as built-in/supported and provides connector/operation metadata mapping.
libs/designer/src/lib/common/constants.ts Adds node type + serialized type constants for FlatFileSchemaGeneration.
libs/designer-v2/src/lib/common/constants.ts Adds node type + serialized type constants for FlatFileSchemaGeneration.

const xmlparse = 'xmlparse';
export const flatfiledecoding = 'flatfiledecoding';
export const flatfileencoding = 'flatfileencoding';
const flatfileschemageneration = 'flatfileschemageneration';
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flatfileschemageneration is introduced as a non-exported const, while the sibling flat file operation type constants (flatfiledecoding, flatfileencoding) are exported and referenced from other modules (e.g., static result schema logic). To keep the API consistent and avoid future string duplication, consider exporting flatfileschemageneration as well.

Suggested change
const flatfileschemageneration = 'flatfileschemageneration';
export const flatfileschemageneration = 'flatfileschemageneration';

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

📊 Coverage Check

No source files changed in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants