Add FlatFileSchemaGeneration as recognized built-in operation type#8890
Add FlatFileSchemaGeneration as recognized built-in operation type#8890anandgmenon wants to merge 3 commits intomainfrom
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | Keep as-is or optionally shorten. |
| Commit Type | ✅ | No change needed. |
| Risk Level | ✅ | Matches risk:low label. |
| What & Why | ✅ | Clear; consider linking issue/ticket. |
| Impact of Change | ✅ | Good coverage. |
| Test Plan | Add unit tests for constants/manifest recognition or justify manual testing. | |
| Contributors | Add contributors or a short note. | |
| Screenshots/Videos | ✅ | Screenshot included. |
Summary: The PR title and body follow the required template and are largely complete and accurate. The code diff is small (3 files changed, ~11 additions), adding constant entries and a manifest mapping — this is consistent with a low-risk change. The advised risk level is risk:low, which matches the label on the PR.
Action items I recommend before merging (minor):
- Add unit tests that assert the new built-in op is recognized (isBuiltInOperation) and present in builtInOperationsMetadata.
- Fix small typo in the Test Plan:
Standalaon designer->Standalone designer. - Add contributors (or a note) in the Contributors section if applicable.
- (Optional) Link any associated issue/bug ticket for traceability.
Please update the PR with the unit tests or a short justification for why automated tests aren't present, fix the minor typo, and add contributors if relevant. Once those are addressed (or explained), this PR is good to merge.
Last updated: Mon, 16 Mar 2026 17:14:35 GMT
There was a problem hiding this comment.
Pull request overview
Adds support across designer services and both designer UI versions for the new built-in operation type FlatFileSchemaGeneration, preventing the designer from incorrectly treating it as swagger-resolved and failing to load affected workflows.
Changes:
- Register
flatfileschemagenerationas a supported built-in/base manifest operation type and map it to the Flat File built-in connector metadata. - Add the new operation type constant to
Constants.NODE.TYPEin both designer (v1) and designer-v2. - Add the new serialized type (
FlatFileSchemaGeneration) toConstants.SERIALIZED_TYPEin both designer (v1) and designer-v2.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| libs/logic-apps-shared/src/designer-client-services/lib/base/operationmanifest.ts | Recognizes flatfileschemageneration as built-in/supported and provides connector/operation metadata mapping. |
| libs/designer/src/lib/common/constants.ts | Adds node type + serialized type constants for FlatFileSchemaGeneration. |
| libs/designer-v2/src/lib/common/constants.ts | Adds node type + serialized type constants for FlatFileSchemaGeneration. |
| const xmlparse = 'xmlparse'; | ||
| export const flatfiledecoding = 'flatfiledecoding'; | ||
| export const flatfileencoding = 'flatfileencoding'; | ||
| const flatfileschemageneration = 'flatfileschemageneration'; |
There was a problem hiding this comment.
flatfileschemageneration is introduced as a non-exported const, while the sibling flat file operation type constants (flatfiledecoding, flatfileencoding) are exported and referenced from other modules (e.g., static result schema logic). To keep the API consistent and avoid future string duplication, consider exporting flatfileschemageneration as well.
| const flatfileschemageneration = 'flatfileschemageneration'; | |
| export const flatfileschemageneration = 'flatfileschemageneration'; |
📊 Coverage CheckNo source files changed in this PR. |
Commit Type
Risk Level
What & Why
The designer fails to load workflows containing the new
FlatFileSchemaGenerationbuilt-in operation. The error:This happens because the designer doesn't recognize
FlatFileSchemaGenerationas a built-in operation type. When it encounters this operation type in a workflow definition, it falls through to the swagger-based API connection resolution path, which doesn't support it.Impact of Change
Test Plan
Contributors
Screenshots/Videos