feat(knowledge): Add list view and delete for knowledge hubs in wizard

[preetriti1]

Commit Type

• feature - New functionality
• fix - Bug fix
• refactor - Code restructuring without behavior change
• perf - Performance improvement
• docs - Documentation update
• test - Test-related changes
• chore - Maintenance/tooling

Risk Level

• Low - Minor changes, limited scope
• Medium - Moderate changes, some user impact
• High - Major changes, significant user/system impact

What & Why

"Adds a list view for Knowledge Hubs and artifacts and a modal to delete hubs/artifacts. Introduces deleteKnowledgeHubArtifacts helper which issues DELETE to ResourceService for hubs and artifacts. Updates shared models and switches ResourceService calls to use knowledgehubs path and api-version 2018-11-01.

The changes in this PR are not changing the behavior of any released production feature, this is a new feature currently in development in backend and UI and apis/data will be getting updated based on initial testing results. This is not a high risk item.

Impact of Change

• Users: New list view and ability to delete hubs/artifacts from the wizard. UX changes/confirmation flows described and screenshot included.
• Developers: New components (KnowledgeList, DeleteModal), helper function deleteKnowledgeHubArtifacts, and modifications to the shared knowledge models. Call out any breaking type changes and required updates in dependent packages.
• System: Network calls now use different endpoints/versions based on backend updated design. This is a new feature so such changes are expected.

Test Plan

• Unit tests added/updated
• E2E tests added/updated
• Manual testing completed
• Tested in:

Contributors

@bonicaayala @ecfan @bjbennet

Screenshots/Videos

[github-actions]

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

• Current: feat(knowledge): Add list view and delete for knowledge hubs in wizard
• Issue: Title is generally clear and follows the conventional style (scope + short summary). It could be slightly more specific about the surface-area (UI + API / shared model changes) but this is optional.
• Recommendation: Keep as-is or make it more explicit if you want to highlight the breaking/infra surface, e.g. feat(knowledge): Add list view + delete for knowledge hubs in wizard (adds API path + model changes)

---

✅ Commit Type

• Properly selected (feature).
• Note: Only one commit type selected, which is correct.

---

⚠️ Risk Level

• Assessment: The PR has the risk:high label and the PR body also selected High under Risk Level. This is correct with respect to the label.
• Note / Concern: The PR body text (What & Why) contains the sentence "The changes in this PR are not changing the behavior of any released production feature... This is not a high risk item." — this contradicts the Risk Level selection. The code diff shows multiple potentially breaking changes (see below), so the High risk level is appropriate.

---

⚠️ What & Why

• Current: "Adds a list view for Knowledge Hubs and artifacts and a modal to delete hubs/artifacts... The changes in this PR are not changing the behavior of any released production feature, this is a new feature... This is not a high risk item."
• Issue: The body claims "not high risk" while the PR selects High and the actual diff introduces breaking-surface changes (shared model changes, API path and api-version changes, new public functions). This contradiction should be resolved and the "What & Why" section should explicitly call out the breaking areas.
• Recommendation: Replace/augment the paragraph with a short, explicit summary and a bullet list of notable, potentially breaking changes. Example to include:
  • "What: Adds Knowledge hubs list UI, delete modal, and helper to delete hubs/artifacts."
  • "Why: Needed for wizard-based management of knowledge hubs and artifacts."
  • "Risk: HIGH — changes below affect runtime behavior and public/shared models:"
    • libs/logic-apps-shared/src/utils/src/lib/models/knowledge.ts — added fields, changed property names and ArtifactCreationStatus values (Processing -> InProgress). This is a breaking change for any consumers of these models.
    • Helper and queries switching to new path and api-version in helper.ts and queries.ts: path changed to knowledgeHubs and api-version to 2018-11-01 (was 2025-11-01). Consumers or backend expectations need to be validated.
    • New UI components and wiring: knowledgelist.tsx, delete.tsx, styles.ts and many tests added/changed — increases surface area and maintenance burden.

---

⚠️ Impact of Change

• Issue: The body mentions "Call out any breaking type changes and required updates in dependent packages" but does not list them explicitly. The diff shows clear breaking-type changes which must be called out and coordinated.
• Recommendation:
  • Users: New list view + delete flows in the wizard. Add a small UX note if any confirmation/behavior differs from existing flows.
  • Developers: Explicitly call out breaking API / model changes and any necessary updates for downstream consumers. Example items to add to the body:
    • "Shared model changes (libs/logic-apps-shared...models/knowledge.ts) changed field names and added required fields — update any package that imports these types."
    • "API path and version changed in helper/queries to '/knowledgehubs' and api-version '2018-11-01' — ensure backend supports this path and version or document migration steps."
    • "New public helpers: deleteKnowledgeHubArtifacts in helper.ts — describe expected return and error behavior for callers."
  • System: Note the backend contract changes (path + api-version) and potential runtime effects — recommend a coordinated deployment or feature flag if backend isn't yet ready.

---

✅ Test Plan

• Assessment: Unit tests are present and updated/added across multiple areas (see below). Manual testing checked. E2E tests are not included.
• Recommendation: Unit tests seen in diff include updates and additions:
  • libs/designer/.../__test__/helper.spec.ts — tests for deleteKnowledgeHubArtifacts
  • Many new UI tests under libs/designer/src/lib/ui/knowledge/.../__test__/*.spec.tsx
  • queries.spec.ts updates
    Ensure your unit tests include failure-case coverage for the new helper and the code that calls the shared models. Because the PR changes API paths and shared models, please either add an E2E/integration test that verifies the API contract against a staging backend or add a short justification why E2E is not needed now and how you will validate backend compatibility in integration testing.

---

✅ Contributors

• Assessment: Contributors are listed (@bonicaayala @ecfan @bjbennet). Good.
• Recommendation: If product/PM/Design helped define UX behavior, consider adding them for traceability, but this is optional.

---

✅ Screenshots/Videos

• Assessment: Screenshot included. Good for a UI change.

---

Summary Table

Section	Status	Recommendation
Title	✅	Minor optional clarity: mention model/API surface if desired.
Commit Type	✅	OK.
Risk Level	⚠️	Keep risk:high label (correct). Remove contradictory sentence in What & Why; explicitly explain why high.
What & Why	⚠️	Explicitly list breaking changes (shared model, API path, api-version), and remove the "not high risk" statement.
Impact of Change	⚠️	Add explicit list of who needs to change (consumers of shared models, backend API compatibility).
Test Plan	✅	Unit tests present — add or justify lack of E2E/integration tests for API/back-end contract changes.
Contributors	✅	OK. Optionally include PM/Design if they contributed to UX.
Screenshots/Videos	✅	OK.

---

Final notes (actionable items)

1. Update the What & Why section to remove the contradictory sentence claiming "not high risk" and explicitly call out the breaking changes identified in the diff (models and API path/version changes). Give a short migration note for consumers of the changed shared models.
2. In Impact of Change, add explicit bullets naming the changed/shared files and the expected impact and required updates for dependent packages. E.g. update any package that imports models/knowledge.ts to use new properties/enum values.
3. Confirm backend compatibility for the path .../knowledgehubs and api-version 2018-11-01. If backend is not yet live, note the coordinated deployment steps or feature flaging/guardrails.
4. Tests: ensure unit tests cover error/failure flows for deleteKnowledgeHubArtifacts and consider adding an integration/E2E test that exercises the HTTP calls against a test/staging backend or add a clear justification in the PR for why not.
5. Optional: adjust PR title to mention major infra/model changes if you want reviewers to notice it quicker.

Advised risk (from the code diff): High — this is higher than the submitter's internal statement in the PR body which called it "not high risk". The code diff shows shared model changes and API path/version changes that are breaking/integration-sensitive and justify the High risk label.

Please update the PR description as recommended above, then re-submit or add a short follow-up comment acknowledging these items. Thank you for the thorough tests and UI coverage — the change is well covered in unit tests but needs a clearer risk and impact callout for reviewers and integrators.

---

Last updated: Wed, 18 Mar 2026 05:40:03 GMT

[Copilot]

Pull request overview

Adds a knowledge hubs/artifacts list experience to the Knowledge Hub wizard, including selection and delete flows, and updates underlying knowledge models/querying to support the new UI.

Changes:

• Introduces a grouped table list view (hubs with expandable artifacts) with multi-select and per-row actions.
• Adds delete confirmation modal + helper to delete hubs/artifacts, and wires delete entry points into the wizard.
• Updates knowledge models, queries, and localization strings; adds unit tests for the new UI/modal behavior.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
libs/logic-apps-shared/src/utils/src/lib/models/knowledge.ts	Updates knowledge hub/artifact model shape (IDs, timestamps, status naming).
libs/designer/src/lib/ui/knowledge/wizard/styles.ts	Adds table/list styling for the new list view.
libs/designer/src/lib/ui/knowledge/wizard/knowledgelist.tsx	New grouped table component with expand/collapse, selection, context menu, and cache updates on delete.
libs/designer/src/lib/ui/knowledge/wizard/knowledgehub.tsx	Replaces placeholder list view with KnowledgeList and adds wizard-level delete modal flow.
libs/designer/src/lib/ui/knowledge/wizard/test/knowledgelist.spec.tsx	Unit tests for list view rendering, selection, menus, and cache updates.
libs/designer/src/lib/ui/knowledge/wizard/test/knowledgehub.spec.tsx	Updates wizard tests to cover list view integration and delete modal enablement.
libs/designer/src/lib/ui/knowledge/modals/styles.ts	Shared modal layout styles for knowledge modals.
libs/designer/src/lib/ui/knowledge/modals/delete.tsx	New delete confirmation dialog that calls delete helper and emits notification data.
libs/designer/src/lib/ui/knowledge/modals/test/delete.spec.tsx	Unit tests for delete modal content, callbacks, loading/error states.
libs/designer/src/lib/core/knowledge/utils/queries.ts	Switches knowledge hubs query to new endpoint/response shape and removes artifact fetch helper.
libs/designer/src/lib/core/knowledge/utils/helper.ts	Updates create hub endpoint/version and adds deletion helper for hubs/artifacts.
Localize/lang/strings.json	Adds localized strings for list view and delete modal messaging.

[github-actions]

📊 Coverage Check

🎉 All changed files have adequate test coverage!

[ecfan]

@preetriti1: Where are the strings "Developer Toolbox", "Standard Logic Apps", and "Dark Mode"?

They should be: "Developer toolbox", "Standard logic apps", and "Dark mode".

[ecfan]

Feedback, added, thanks!

[preetriti1]

@preetriti1: Where are the strings "Developer Toolbox", "Standard Logic Apps", and "Dark Mode"?

They should be: "Developer toolbox", "Standard logic apps", and "Dark mode".

These are test page file... you can skip anything inside apps/ folder in this PR