Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
isra-fel
requested review from
DanielMicrosoft,
ReaNAiveD,
necusjz and
yonzhan
as code owners
❌AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Azure CLI’s core dependency set to use azure-core 1.39.0, aligning both the azure-cli-core package dependency range and the platform-specific pinned requirements used by azure-cli.
Changes:
- Bump
azure-coreinazure-cli-corefrom~=1.38.0to~=1.39.0. - Pin
azure-corein platform requirements files from==1.38.0to==1.39.0(Darwin/Linux/Windows).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli-core/setup.py | Updates azure-cli-core dependency range to azure-core~=1.39.0. |
| src/azure-cli/requirements.py3.Darwin.txt | Pins azure-core to 1.39.0 for macOS builds. |
| src/azure-cli/requirements.py3.Linux.txt | Pins azure-core to 1.39.0 for Linux builds. |
| src/azure-cli/requirements.py3.windows.txt | Pins azure-core to 1.39.0 for Windows builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
microsoft-github-policy-service
bot
added
Auto-Assign
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
N/A - dependency update
Description
Bump
azure-corefrom 1.38.0 to 1.39.0.This update picks up the rename of the
AZURE_CLOUDenvironment variable toAZURE_SDK_CLOUD_CONF(Azure/azure-sdk-for-python#45763). The oldAZURE_CLOUDvariable was too general that it conflicted with other software, causing ValueError: Cannot convert AzureCloud to Azure Cloud when its value is not understood by SDK. With this bump,azure-corestops readingAZURE_CLOUDand readsAZURE_SDK_CLOUD_CONFinstead, resolving the conflict.Testing Guide
Ran
azure-cli-coreunit tests locally — no new failures introduced by this change.History Notes
[Core] Bump
azure-coreto 1.39.0 to resolveValueErrorcaused byAZURE_CLOUDenvironment variable conflictThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.