Changed the azure_cloud setting environment variable#45763
Open
xiangyan99 wants to merge 1 commit intomainfrom
Open
Changed the azure_cloud setting environment variable#45763xiangyan99 wants to merge 1 commit intomainfrom
azure_cloud setting environment variable#45763xiangyan99 wants to merge 1 commit intomainfrom
Conversation
…OUD` to `AZURE_SDK_CLOUD_CONF`.
xiangyan99
changed the title
azure_cloud setting environment variable from `AZURE_CL…azure_cloud setting environment variable
xiangyan99
requested review from
annatisch,
iscai-msft,
johanste,
kashifkhan,
lmazuel and
pvaneck
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates azure-core’s global settings to read the azure_cloud setting from a new environment variable name, and updates tests/changelog accordingly.
Changes:
- Renamed the
azure_cloudsetting env var fromAZURE_CLOUDtoAZURE_SDK_CLOUD_CONF. - Updated
test_settings.pyto set/unset the new env var intest_current. - Documented the rename in
azure-core’s changelog as a breaking change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/core/azure-core/azure/core/settings.py | Switches Settings.azure_cloud to read from AZURE_SDK_CLOUD_CONF. |
| sdk/core/azure-core/tests/test_settings.py | Updates environment-variable-based test to use the new name. |
| sdk/core/azure-core/CHANGELOG.md | Notes the env var rename under Breaking Changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the
azure_cloudsetting environment variable fromAZURE_CLOUDtoAZURE_SDK_CLOUD_CONF.