[202503] BGP confederation support for Disaggregated T2#2189
Open
bingwang-ms wants to merge 1 commit into
Open
[202503] BGP confederation support for Disaggregated T2#2189bingwang-ms wants to merge 1 commit into
bingwang-ms wants to merge 1 commit into
Conversation
Port of sonic-net/sonic-buildimage#26427 to 202511 branch. Add BGP confederation configuration support for disaggregated T2 devices (LowerSpineRouter, UpperSpineRouter, FabricSpineRouter). Changes: - YANG model: Add CONFED container to sonic-bgp-device-global with asn and members fields - FRR templates: Add confederation identifier and peers config to bgpd.main.conf.j2, instance.conf.j2, and peer-group.conf.j2 - Constants: Add hide_internal_community for disaggregated T2 topologies - Documentation: Update Configuration.md with CONFED schema - Unit tests: Add bgpcfgd, config-engine, and YANG model test cases Signed-off-by: arlakshm <arlakshm@microsoft.com>
bingwang-ms
requested review from
StormLiangMS,
lguohan and
qiluo-msft
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of sonic-net/sonic-buildimage#26761 onto the
202503branch.Original PR: sonic-net/sonic-buildimage#26761
Merge Conflict
File:
src/sonic-bgpcfgd/tests/test_sonic-cfggen.pytest_bgpd_main_conf_defaults_router_id()— no radian or confederation test cases.test_prefix_list_add_radian,test_prefix_list_del_radian,test_bgp_confed_ut2_multi_asic,test_bgp_confed_ut2_single_asic,test_bgp_confed_lt2_single_asic,test_bgp_confed_ft2_single_asic.Resolution: Accepted all incoming additions from the PR — the 202503 base simply lacked these new tests, so all new test functions were appended.