Skip to content

test(mock-sync): assert mock controller/pipe-state/capture-file method surfaces match real renderdoc#249

Merged
BANANASJIM merged 2 commits into
masterfrom
fix/rdc-mock-method-sync
Jun 16, 2026
Merged

test(mock-sync): assert mock controller/pipe-state/capture-file method surfaces match real renderdoc#249
BANANASJIM merged 2 commits into
masterfrom
fix/rdc-mock-method-sync

Conversation

@BANANASJIM

Copy link
Copy Markdown
Owner

test_mock_api_sync.py only checked enums and struct fields, never method surfaces, so a renamed or removed upstream renderdoc method passes CI green while the mock keeps the stale name.

Adds a gpu-marked test_mock_methods_exist_on_real asserting every API-style method the mock claims still exists on the real ReplayController/PipeState/CaptureFile, with an explicit KNOWN_MOCK_ONLY allowlist, a negative guard against silent no-ops, and CPU-tier tests for the comparison helpers. Test-only. Unit suite 2992 passed.

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@BANANASJIM, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 13 minutes and 34 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 27fc91bd-d93b-4a93-86ce-6cfbe747367c

📥 Commits

Reviewing files that changed from the base of the PR and between 76c6bea and 16ea408.

📒 Files selected for processing (2)
  • ruff.toml
  • tests/integration/test_mock_api_sync.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rdc-mock-method-sync

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@BANANASJIM BANANASJIM merged commit a98ec12 into master Jun 16, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant