build: add renderdoc pin-consistency test locking RDOC_TAG/SWIG_SHA256 to a single source#250
build: add renderdoc pin-consistency test locking RDOC_TAG/SWIG_SHA256 to a single source#250BANANASJIM wants to merge 3 commits into
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Warning Review limit reached
More reviews will be available in 11 minutes and 22 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
1 participant
_build_renderdoc.pyalready definesRDOC_TAGandSWIG_SHA256constants, but six build definitions (Dockerfile, both PKGBUILDs, two shell scripts) hard-code the same values with nothing to keep them in sync.Adds
test_renderdoc_pin_consistencyasserting every renderdoc-referencing build file pins the sameRDOC_TAG, and every SWIG-fetching file pins the sameSWIG_SHA256. Two documented exclusions:docker/Dockerfiledoes not fetch the SWIG fork, andscripts/setup-renderdoc.shfetches without sha verification. Test-only, no build-behavior change. Unit suite 2993 passed.Held for a follow-up (needs a real docker build to validate): the Dockerfile not building the SWIG fork at all.