4 add logic to enabledisable controls#29
Merged
Conversation
…ans are selected)
…ement buttons enabled only when plans are selected)
…run engine controls)
- Show error dialog when connection is lost after successful connection - Skip dialog on startup if auto-connect fails (expected behavior) - Use QTimer to show dialog asynchronously to avoid blocking event loop - Track connection state to distinguish startup failures from runtime disconnections
- Connect runEngineUpdateButton to do_RE_update method - Implement do_RE_update - Add context-aware enable/disable for update button (enabled when connected and worker exists) - Add critical error dialogs for API errors in queue and RE control methods
Uses bind_plan_arguments() from bluesky-queueserver to convert positional arguments back to keyword arguments based on plan signatures. This enables proper parameter name extraction for display in table models.
- history_model.py: Use get_bound_item_arguments() to properly extract parameters. Put args into kwargs as 'args' when binding fails. - history_model_dynamic.py: Extract VAR_POSITIONAL from kwargs when binding succeeds to display in 'args' column. Put args into kwargs as 'args' when binding fails. - history.py: Added re-render logic in onStatusChanged() to fix first-load issue when plans aren't loaded yet. Re-renders dynamic model once when plans become available.
- queue_model.py: Use get_bound_item_arguments() to properly extract parameters. Put args into kwargs as 'args' when binding fails. - queue_model_dynamic.py: Extract VAR_POSITIONAL from kwargs when binding succeeds to display in 'args' column. Put args into kwargs as 'args' when binding fails. - queue_editor.py: Added re-render logic in onStatusChanged() to fix first-load issue when plans aren't loaded yet. Re-renders dynamic model once when plans become available.
Contributor
Author
|
#30 fixed for both queue table views as well as plan editor (load parameters properly when using 
|
Collaborator
|
I noticed in the plan editor, when updating an existing task, I clicked on the detectors value cell to edit it (was a list containing All other button disable/enable, color changes, etc. look great. |
prjemian
approved these changes
Dec 8, 2025
prjemian
left a comment
prjemian
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, with one comment for the plan editor.
Contributor
Author
I created a separate issue #31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.