Open
Conversation
KYM-P
reviewed
Jan 10, 2026
Collaborator
KYM-P
left a comment
KYM-P
left a comment
There was a problem hiding this comment.
GOOD
다만 clean architecture 적용도 해보셨으면 좋을 것 같고,
모든 파일을 android_25_2/ 경로에 넣지 않고 분할했으면 좋겠으며
본인 코드에 대한 이해도를 가져가시길 바랍니다.
| ): List<Repository> | ||
|
|
||
| companion object { | ||
| fun create(): GitHubApiService { |
Collaborator
There was a problem hiding this comment.
개인적으로는 따로 빼두는게 더 좋을 것 같긴 합니다.
interface 내부에 실제 create 부분을 두는건 어색하네요
| enableEdgeToEdge() | ||
| setContentView(R.layout.activity_main) | ||
| ViewCompat.setOnApplyWindowInsetsListener(findViewById(R.id.main)) { v, insets -> | ||
| Log.d("MainActivity", "🚀 onCreate 시작") |
|
|
||
| class RepositoryAdapter( | ||
| private val onItemClick: (String) -> Unit | ||
| ) : ListAdapter<Repository, RepositoryViewHolder>(RepositoryDiffCallback()) { |
|
|
||
| private val apiService = GitHubApiService.create() | ||
| private val _repositories = MutableLiveData<List<Repository>>() | ||
| val repositories: LiveData<List<Repository>> = _repositories |
| viewModel = ViewModelProvider(this)[RepositoryViewModel::class.java] | ||
| val username = intent.getStringExtra(user_name) ?: "" | ||
|
|
||
| title = "$username's Repositories" |
Collaborator
There was a problem hiding this comment.
texts.xml 도 사용할 수 있습니다. "%1$s's Repositories" 로 선언해서 getString 으로 가져올 수 있죠
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.